Skip to content

Remove gulp-imagemin#10435

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-gulp-imagemin
Feb 15, 2021
Merged

Remove gulp-imagemin#10435
Gudahtt merged 1 commit intodevelopfrom
remove-gulp-imagemin

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Feb 12, 2021

This package hasn't been used since #8140, which dropped it for being too slow and of minimal benefit.

We should consider re-adding this as a CI check to ensure images are optimized, but I don't think it should be re-added to the build process itself.

@Gudahtt Gudahtt requested a review from a team as a code owner February 12, 2021 17:41
@Gudahtt Gudahtt requested a review from danjm February 12, 2021 17:41
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [81cd0e4]
Page Load Metrics (572 ± 11 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45735894
domContentLoaded5106265712412
load5116275722411
domInteractive5106255702412

@Gudahtt Gudahtt force-pushed the remove-gulp-imagemin branch from 81cd0e4 to 122d54a Compare February 13, 2021 18:48
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [122d54a]
Page Load Metrics (553 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44765684
domContentLoaded3517525529445
load3537535539445
domInteractive3517515529445

brad-decker
brad-decker previously approved these changes Feb 13, 2021
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [a1874f7]
Page Load Metrics (522 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42624852
domContentLoaded3345795206230
load3355795226130
domInteractive3345785206130

This package hasn't been used since #8140, which dropped it for being
too slow and of minimal benefit.

We should consider re-adding this as a CI check to ensure images are
optimized, but I don't think it should be re-added to the build process
itself.
@Gudahtt Gudahtt force-pushed the remove-gulp-imagemin branch from a1874f7 to 7f69a0c Compare February 15, 2021 14:34
@darkwing darkwing self-requested a review February 15, 2021 14:36
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [7f69a0c]
Page Load Metrics (586 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45725994
domContentLoaded3697515858641
load3707535868641
domInteractive3687515858641

@Gudahtt Gudahtt merged commit 8a76dcc into develop Feb 15, 2021
@Gudahtt Gudahtt deleted the remove-gulp-imagemin branch February 15, 2021 15:20
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants