Merged
Conversation
Sync `master` with `develop`
This restores support for versions of the inpage provider prior to v8. This is intended to support dapps and extensions that directly instantiated their own provider rather than using the injected provider. * Forward traffic between old and new provider streams * Ignore publicConfig stream for non-legacy muxes * Transform accountsChanged notification for legacy streams * Convert publicConfigStore to singleton Co-authored-by: Mark Stacey <markjstacey@gmail.com>
The "Confirm public encryption key" page will now no longer crash when the domain metadata is missing.
Collaborator
Author
Builds ready [ad12abb]
Page Load Metrics (467 ± 34 ms)
|
Collaborator
Author
Builds ready [6af62a3]
Page Load Metrics (531 ± 36 ms)
|
olivertaxi
previously approved these changes
Jan 13, 2021
Gudahtt
previously approved these changes
Jan 13, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM!
Tested with a few popular dapps, and everything seemed to work. I've tested with my temporary fork of the test dapp with an embedded legacy provider quite extensively as well, and everything seemed to work. I can't reproduce the UI crash I saw earlier either.
I didn't know how to test #10169, but, that change doesn't seem particularly risky.
All four changes were user-facing in this case.
e41f34b
6af62a3 to
e41f34b
Compare
Collaborator
Author
Builds ready [e41f34b]
Page Load Metrics (505 ± 39 ms)
|
tmashuang
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 🚀
Changelog