Skip to content

Detect tokens on custom Mainnet RPC endpoints#10157

Merged
Gudahtt merged 1 commit intodevelopfrom
detect-tokens-on-custom-mainnet-rpc-endpoints
Jan 8, 2021
Merged

Detect tokens on custom Mainnet RPC endpoints#10157
Gudahtt merged 1 commit intodevelopfrom
detect-tokens-on-custom-mainnet-rpc-endpoints

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 7, 2021

Our automatic token detection was hard-coded to only work on our built-in Infura Mainnet endpoint. It now works with custom Mainnet RPC endpoints as well.

Relates to #6992

Manual testing steps:

  • Add a custom RPC endpoint for Mainnet (e.g. https://cloudflare-eth.com/ )
  • Import an account with a non-zero amount of tokens on Mainnet
  • Wait for those tokens to show up automatically

Our automatic token detection was hard-coded to only work on our built-
in Infura Mainnet endpoint. It now works with custom Mainnet RPC
endpoints as well.

Relates to #6992
@Gudahtt Gudahtt requested a review from a team as a code owner January 7, 2021 18:56
@Gudahtt Gudahtt requested a review from rekmarks January 7, 2021 18:56
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [56e5cea]
Page Load Metrics (546 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39664973
domContentLoaded32870054411455
load32970354611455
domInteractive32770054411455

Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 69e883c into develop Jan 8, 2021
@Gudahtt Gudahtt deleted the detect-tokens-on-custom-mainnet-rpc-endpoints branch January 8, 2021 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants