Skip to content

@metamask/contract-metadata@1.21.0#10142

Merged
rekmarks merged 2 commits intodevelopfrom
@metamask/contract-metadata@1.21.0
Jan 5, 2021
Merged

@metamask/contract-metadata@1.21.0#10142
rekmarks merged 2 commits intodevelopfrom
@metamask/contract-metadata@1.21.0

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Jan 5, 2021

  • Minor version bump

@rekmarks rekmarks requested a review from a team as a code owner January 5, 2021 16:16
@rekmarks rekmarks requested a review from darkwing January 5, 2021 16:16
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [087596f]
Page Load Metrics (694 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4210062136
domContentLoaded33490569116579
load33790669416278
domInteractive33490469116579

yarn.lock Outdated
react-is "^16.8.0"

"@metamask/contract-metadata@^1.19.0", "@metamask/contract-metadata@^1.20.0":
"@metamask/contract-metadata@^1.19.0":
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we dedupe this entry too? This range is compatible with 1.21.0

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [0a7105e]
Page Load Metrics (514 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30554484
domContentLoaded3045925126732
load3055945146732
domInteractive3045925126732

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 6abb32f into develop Jan 5, 2021
@rekmarks rekmarks deleted the @metamask/contract-metadata@1.21.0 branch January 5, 2021 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants