add module resolution for node-analytics/axios#10139
Merged
brad-decker merged 1 commit intodevelopfrom Jan 4, 2021
Merged
Conversation
Collaborator
Builds ready [f2f5209]
Page Load Metrics (662 ± 48 ms)
|
rekmarks
approved these changes
Jan 4, 2021
Member
rekmarks
left a comment
There was a problem hiding this comment.
I reviewed the axios changelog and node-analytics usage thereof, and also found nothing concerning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analytics-nodeusesaxiosfor network requests, and has version resolution set to^0.19but due toaxiosbeing pre-version 1, minor version bumps do not get installed automatically because all pre-v1 changes should be considered breaking. This module resolution will likely be used throughout the life of our dependency onanalytics-nodeuntil such a time asaxiosmoves to version 1. This will allow us to take advantage of security and stability improvements in the underlying request library.I tested locally using the mock-segment server in a variety of situations using firefox with ETP on, as well as chrome, and did not see any issue. I also reviewed the changes to
axiosfrom0.19.2to0.21.1and nothing stood out as being concerning.