Fix useTransactionDisplayData unit tests#10134
Merged
Conversation
brad-decker
previously approved these changes
Jan 4, 2021
Member
Author
|
cc: @Gudahtt we found the problem |
ae56d13 to
8acda7b
Compare
8acda7b to
f61ef74
Compare
Gudahtt
approved these changes
Jan 4, 2021
Collaborator
Builds ready [f61ef74]
Page Load Metrics (520 ± 58 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New year, new problems.
It's working as expected, but we had hard-coded some 2020 date values, and
formatDateWithYearContextadds the year to its output formatted date if the date is not from the current year.Edit: We should add cases dynamically testing the behavior for the current year, but let's do that in a follow-up.