Skip to content

Remove unnecessary swaps footer space when in dropdown mode#10100

Merged
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:swaps-dropdown-footer-height
Dec 18, 2020
Merged

Remove unnecessary swaps footer space when in dropdown mode#10100
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:swaps-dropdown-footer-height

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

Explanation: When we moved the TOS link from the view quote screen to the build quote screen, we left behind an artifact of the UI, namely extra space:

Before

FooterBefore

After

FooterAfter

@darkwing darkwing requested a review from a team as a code owner December 17, 2020 17:43
@darkwing darkwing requested a review from Gudahtt December 17, 2020 17:43
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit d4d3d6a into MetaMask:develop Dec 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants