Fix #10081 - Use fetchWithCache to retrieve and store basic gas estimates#10098
Closed
darkwing wants to merge 1 commit intoMetaMask:developfrom
Closed
Fix #10081 - Use fetchWithCache to retrieve and store basic gas estimates#10098darkwing wants to merge 1 commit intoMetaMask:developfrom
darkwing wants to merge 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
20865fa to
561e7cd
Compare
561e7cd to
4895e6c
Compare
Gudahtt
requested changes
Jan 22, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
This looks great! Looks pretty close to ready after a rebase.
| } | ||
| } | ||
|
|
||
| export function resetCustomGasState() { |
Member
There was a problem hiding this comment.
I was about to ask why this was removed as well, but I think I see now. It's dead code.
Contributor
Author
|
Superceded by #10384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10081
Explanation: It appears we're currently fetching basic gas estimates and storing the result along with last fetched time, and then doing expiration validation, when
fetchWithCachecan do all of this for us.Currently a WIP. Fighting with
proxyquireto ensure storage can be stub'd inui/app/helpers/utils/fetch-with-cache.js