Update @metamask/controllers to v5.1.0#10096
Merged
Conversation
This update comes with a breaking change to the Approval controller. It now requires a `defaultApprovalType` parameter. I don't think we have any use for a default approval type, but I've added a "NO_TYPE" one for now because it's a strict requirement. We should consider making this parameter optional in the future, for cases like this where it's not needed. This update will hopefully address some caching issues we've been seeing with our phishing configuration. See here for more details: MetaMask/core#297
0659dde to
bdc7934
Compare
Collaborator
Builds ready [bdc7934]
Page Load Metrics (554 ± 44 ms)
|
brad-decker
approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update comes with a breaking change to the Approval controller. It now requires a
defaultApprovalTypeparameter.I don't think we have any use for a default approval type, but I've added a "NO_TYPE" one for now because it's a strict requirement. We should consider making this parameter optional in the future, for cases like this where it's not needed.
This update will hopefully address some caching issues we've been seeing with our phishing configuration. See here for more details: MetaMask/core#297