Skip to content

Version v8.1.7 RC#10020

Merged
danfinlay merged 4 commits intomasterfrom
Version-v8.1.7
Dec 9, 2020
Merged

Version v8.1.7 RC#10020
danfinlay merged 4 commits intomasterfrom
Version-v8.1.7

Conversation

@metamaskbot
Copy link
Copy Markdown
Collaborator

@metamaskbot metamaskbot commented Dec 8, 2020

📦 🚀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 8, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

metamaskbot commented Dec 8, 2020

Builds ready [e489a58]
Page Load Metrics (611 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34675084
domContentLoaded5197766108038
load5207776118038
domInteractive5197766098038

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

metamaskbot commented Dec 9, 2020

Builds ready [882becb]
Page Load Metrics (580 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint336546105
domContentLoaded5236715793919
load5246715803919
domInteractive5226705783919

tmashuang
tmashuang previously approved these changes Dec 9, 2020
View reviewed changes
@Gudahtt Gudahtt dismissed stale reviews from ghost and tmashuang via 32e8087 December 9, 2020 04:28
tmashuang
tmashuang approved these changes Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, working with the imported zip folder.

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

metamaskbot commented Dec 9, 2020

Builds ready [3160b9b]
Page Load Metrics (331 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint287041115
domContentLoaded2575643297838
load2615653317838
domInteractive2575643297838

@Gudahtt Gudahtt marked this pull request as ready for review December 9, 2020 04:58
@Gudahtt Gudahtt requested review from a team and kumavis as code owners December 9, 2020 04:58
@Gudahtt Gudahtt self-requested a review December 9, 2020 04:58
Gudahtt
Gudahtt approved these changes Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've tested the .zip with Firefox, and it seems to work.

@danfinlay danfinlay merged commit 1a3d3b4 into master Dec 9, 2020
@danfinlay danfinlay deleted the Version-v8.1.7 branch December 9, 2020 05:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@kumavis kumavis Awaiting requested review from kumavis

+1 more reviewer

@tmashuang tmashuang tmashuang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@metamaskbot @Gudahtt @tmashuang @danfinlay