Skip to content

Increase Chrome minimum version#10019

Merged
Gudahtt merged 1 commit intodevelopfrom
update-chrome-minimum-version
Dec 10, 2020
Merged

Increase Chrome minimum version#10019
Gudahtt merged 1 commit intodevelopfrom
update-chrome-minimum-version

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Dec 8, 2020

The Chrome minimum version has been increased from v58 to v63. We found that we had very few users on versions below v63, and v62 is incompatible with our SES lockdown dependency.

This also makes us compatible with Object rest/spread syntax, so we might not have to transpile that anymore. I'll revisit that separately.

The Chrome minimum version has been increased from v58 to v63. We found
that we had very few users on versions below v63, and v62 is
incompatible with our SES lockdown dependency.

This also makes us compatible with Object rest/spread syntax, so we
might not have to transpile that anymore. I'll revisit that separately.
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Dec 8, 2020

We can merge this after v8.1.7 v8.1.8, so that any users on older Chrome versions will at least get that update. That way we'll at least see error reports from them. The only known broken thing for them is the lockdown step.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e128a94]
Page Load Metrics (523 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint306447105
domContentLoaded3105845225526
load3115865235526
domInteractive3105845225526

@Gudahtt Gudahtt marked this pull request as ready for review December 9, 2020 23:15
@Gudahtt Gudahtt requested a review from a team as a code owner December 9, 2020 23:15
@Gudahtt Gudahtt requested a review from rekmarks December 9, 2020 23:15
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 4587e98 into develop Dec 10, 2020
@Gudahtt Gudahtt deleted the update-chrome-minimum-version branch December 10, 2020 05:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants