Skip to content

[Bug]: Duplicate accounts in the vault break some user actions #32935

@mikesposito

Description

@mikesposito

Describe the bug

After #32097 has been fixed, users with duplicates can log in again. However, they can't take any action that requires the vault to be updated, as they still have duplicates.

Expected behavior

Users with duplicates in the vault should be able to add new accounts and sign transactions. Also, duplicates shouldn't be visible in the account list.

Screenshots/Recordings

No response

Steps to reproduce

  1. Switch to the v11.7.3 branch, build locally, and install the extension from chrome://extensions
  2. Onboard with an SRP of which we know the second account (child guilt hollow arrive average popular nasty soon summer like scheme diary pill country rapid)
  3. Import an account that is part of the mnemonic ( 0x80842b7e3cfb1118e86a427cdec418e3b4179ef5bbbfd71c02a76349831c8a8b which is the account at index 2 of the above SRP)
  4. Add a new account on the main HD
  5. Switch to Version-v12.17.1 branch, and refresh the extension in chrome://extensions
  6. Unlock the wallet, you should see duplicates in your accounts list and you won't be able to add new accounts

Error messages or log output

May be visible in the console:

KeyringController - The account you are trying to import is a duplicate

Detection stage

In production (default)

Version

>=12.17.1

Build type

None

Browser

Chrome, Firefox, Microsoft Edge, Brave

Operating system

Linux, Windows, MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

Metadata

Metadata

Assignees

Labels

Sev1-highHigh severity; partial loss of service with severe impact upon users, with no workaround.regression-RC-12.18.0Regression bug that was found in release candidate (RC) for release 12.18.0release-12.20.0Issue or pull request that will be included in release 12.20.0release-blockerThis bug is blocking the next releasetype-bugSomething isn't working

Type

No fields configured for Bug.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions