sdk web3auth (#31) * chore: bump `@metamask-tron-snap-wallet` to `^1.25.0` (#41103) ## **Description** `@metamask/tron-wallet-snap` has been updated to `^1.25.0` to include the following changes: ```markdown ## [1.25.0] ### Changed - Optimize account discovery by using a lightweight activity check (`limit=1`) instead of fetching full transaction history ([#252](https://github.com/MetaMask/snap-tron-wallet/pull/252)) ### Fixed - Avoid `onAmountInput` fee estimation failures by skipping fee validation until a recipient address is available ([#259](https://github.com/MetaMask/snap-tron-wallet/pull/259)) - Assert transaction structure at all entry points, rejecting malformed transactions ([#237](https://github.com/MetaMask/snap-tron-wallet/pull/237)) - Disable scanning of unsupported contract types, preventing incorrect security alerts from blocking user flows ([#238](https://github.com/MetaMask/snap-tron-wallet/pull/238)) - Supported transactions are those single-contract interaction transactions of the following types: `TransferContract`, `CreateSmartContract`, `TriggerSmartContract`. - Unsupported transactions will show empty estimated changes and allow the user to proceed without blocking the confirmation. - Correctly fetch and return staking rewards ([#242](https://github.com/MetaMask/snap-tron-wallet/pull/242)) - Fix revert simulation error when sending TRC20 tokens ([#261](https://github.com/MetaMask/snap-tron-wallet/pull/261)) - Fix infinite loading during fee estimation ([#258](https://github.com/MetaMask/snap-tron-wallet/pull/258)) - The issue was caused by a deadlock during cache updates of chain parameters. ## [1.24.0] ### Added - Implement `claimUnstakedTrx` client request method ([#231](https://github.com/MetaMask/snap-tron-wallet/pull/231)) - Implement `claimTrxStakingRewards` client request method ([#232](https://github.com/MetaMask/snap-tron-wallet/pull/232)) - Add confirmation dialog to `claimUnstakedTrx` method ([#236](https://github.com/MetaMask/snap-tron-wallet/pull/236)) ### Fixed - Always extract special assets to prevent stale balances when amounts drop to zero ([#234](https://github.com/MetaMask/snap-tron-wallet/pull/234)) - Add confirmation dialog to `claimUnstakedTrx` method ([#236](https://github.com/MetaMask/snap-tron-wallet/pull/236)) ## [1.23.1] ### Changed - Tweak asset symbols for the 3 new staking special assets: "In Lock Period" TRX, "Ready for Withdrawal" TRX and "Staking Rewards" TRX ([#227](https://github.com/MetaMask/snap-tron-wallet/pull/227)) ## [1.23.0] ### Added - Add "Ready for Withdrawal" TRX as a special asset to display unstaked TRX that has completed the withdrawal period and is ready to be claimed ([#208](https://github.com/MetaMask/snap-tron-wallet/pull/208)) - Add "Staking Rewards" TRX asset to display unclaimed voting rewards ([#209](https://github.com/MetaMask/snap-tron-wallet/pull/209)) - Return "In Lock Period" TRX as a special asset showing TRX that is unstaked but still in the 14-day lock period ([#210](https://github.com/MetaMask/snap-tron-wallet/pull/210)) ``` [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/41103?quickstart=1) ## **Changelog** CHANGELOG entry: Fixed a bug that was causing issues with TRC20 token transfers ## **Related issues** Fixes: ## **Manual testing steps** 1. Initiate a TRC20 token transfer (e.g., USDT) 2. Type in a valid recipient address and amount 3. Observe that the button does not show an error 4. Click the button to proceed with the transfer 5. Observe that the confirmation screen is shown with no simulation error ## **Screenshots/Recordings** ### **Before** ### **After** https://github.com/user-attachments/assets/7d63e10a-a5f9-48e1-a4b4-d59c147a5b3b ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Medium Risk** > Updates a chain-specific wallet snap dependency, which can change Tron transaction handling and staking/balance behaviors at runtime. Risk is moderated by being largely an upstream version bump with corresponding e2e fixture updates. > > **Overview** > Bumps `@metamask/tron-wallet-snap` from `1.22.1` to `^1.25.0` (and updates `yarn.lock`) to pull in upstream fixes and enhancements. > > Updates the `test/e2e/tests/settings/state-logs.json` fixture to include additional Tron “special assets” and balances (`195-ready-for-withdrawal`, `195-in-lock-period`, `195-staking-rewards`) so state logs tests match the newer snap output. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
adb41e99c4c67e70b211ee8c64ef416dc3b02bbf. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} --------- Co-authored-by: HJetpoluru Co-authored-by: Harika <153644847+hjetpoluru@users.noreply.github.com> * feat(bridge): add data-asset-id for bridge asset rows and chips (#41369) ## **Description** Bridge swap UI already exposes `data-testid` on asset rows and token chips. This augments it with the assetId This lets external regression / Playwright suites select and assert the intended token by stable id instead of symbol text alone (e.g. avoiding ambiguity between similarly named assets). ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Build or start the extension and open **Swap / Bridge** (prepare bridge page). 2. Open the source or destination token picker and inspect a list row in DevTools: the row should include `data-asset-id` matching the token’s CAIP id. 3. With a token selected, inspect the source/destination chip button: it should include `data-asset-id` for the current token. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Low Risk** > Low risk UI instrumentation change that mainly affects automation selectors; primary risk is breaking existing E2E/tests or external suites relying on the old `data-testid="bridge-asset"` value. > > **Overview** > Updates Bridge asset picker rows to expose a stable, asset-specific identifier by changing `BridgeAsset` row `data-testid` from a constant `bridge-asset` to `bridge-asset--${asset.assetId}`. > > Aligns unit snapshots and tests to query asset rows via a regex (`/^bridge-asset--/`) and updates E2E page objects (`swap-page` and `quote-page`) to select asset rows using the new `data-testid` prefix selector. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
516134af41b372773ea5ce559210357dc1a93022. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * chore(deps): upgrade @metamask/design-system-react to 0.12.0 (#41367) ## **Description** Upgrades the extension design-system dependency to the latest release line by bumping `@metamask/design-system-react` from `^0.11.0` to `^0.12.0`. This also updates lockfile resolutions and refreshes generated dependency artifacts. https://github.com/MetaMask/metamask-design-system/releases/tag/v26.0.0 ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: N/A ## **Manual testing steps** 1. Run `yarn webpack --watch` 2. Check extension loads as expected ## **Screenshots/Recordings** ### **Before** `TextButton` had a background color on hover https://github.com/user-attachments/assets/3ed7c7d7-1c35-4643-9d40-121a30d29a7b ### **After** `TextButton` works a expected with removed styles https://github.com/user-attachments/assets/39fadb29-25ea-4466-83cf-6f0d72cb75a3 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Medium Risk** > Dependency upgrade may subtly change styling/behavior of shared UI components across the extension. Changes are mostly lockfile/snapshot updates, but regressions could surface in untested screens. > > **Overview** > Upgrades `@metamask/design-system-react` to `^0.12.0` (and corresponding `@metamask/design-system-shared` resolution) with updated `yarn.lock` entries. > > Refreshes several UI Jest snapshots where generated link/button class names changed (notably removal of some `hover:bg-hover`/`active:bg-pressed` classes), aligning tests with the new design-system output. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
5fe383cea85790f814c6a5064783b11b72c08ec9. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * fix: localized connect message (#41417) ## **Description** This PR fixes the to use a localized message for the loading text in the Connect Hardware flow. ## **Changelog** CHANGELOG entry: Localize `Looking for your ` mesage ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1403?atlOrigin=eyJpIjoiNWM4YjJlMmIxZWNiNGU2MmEwZTA1N2ZiMjMzZTI0YWYiLCJwIjoiaiJ9 ## **Manual testing steps** 1. Go to add hardware wallet 2. Connect a ledger device 3. See the loading message as `Looking for Ledger` ## **Screenshots/Recordings** No visual difference. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Low Risk** > Low risk: only changes the loading indicator string for hardware wallet connection and adjusts unit tests and locale files; no business logic or security-sensitive flows are modified. > > **Overview** > Uses a new i18n key (`hardwareWalletLookingForDevice`) to render the *Connect Hardware* loading indicator instead of a hardcoded English string. > > Adds the corresponding locale entries (US/GB English) and updates `connectHardware` action tests to pass a translation function and assert the localized loading message. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
430ea29fdf74d2381ebc5284324432393dffb508. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com> * bump: lodash and lodash-es to fix audit (#41434) ## **Description** Fix audit problem of `lodash-es` There is also an "invisible" problem with `lodash`, I think yarn might not have noticed it because of the patch. ``` ├─ lodash-es │ ├─ ID: 1115805 │ ├─ Issue: lodash vulnerable to Code Injection via `_.template` imports key names │ ├─ URL: https://github.com/advisories/GHSA-r5fr-rjxr-66jc │ ├─ Severity: high │ ├─ Vulnerable Versions: >=4.0.0 <=4.17.23 │ │ │ ├─ Tree Versions │ │ └─ 4.17.23 │ │ │ └─ Dependents │ └─ @myx-trade/sdk@npm:0.1.271 │ └─ lodash-es ├─ ID: 1115809 ├─ Issue: lodash vulnerable to Prototype Pollution via array path bypass in `_.unset` and `_.omit` ├─ URL: https://github.com/advisories/GHSA-f23m-r3pf-42rh ├─ Severity: moderate ├─ Vulnerable Versions: <=4.17.23 │ ├─ Tree Versions │ └─ 4.17.23 │ └─ Dependents └─ @myx-trade/sdk@npm:0.1.271 ``` ## **Changelog** CHANGELOG entry: null --- > [!NOTE] > **Medium Risk** > Updates a widely-used utility dependency and its Yarn patch, which could cause subtle runtime behavior changes across the app despite being a targeted security/audit fix. > > **Overview** > Bumps `lodash` and `lodash-es` to `4.18.1` (from `4.17.23`) to address reported security advisories, updating both `package.json` resolutions/dependencies and `yarn.lock`. > > Refreshes the Yarn patch applied to `lodash` for Firefox content-script compatibility by switching Lodash’s global detection from `global` to `globalThis` in `_freeGlobal.js`, `core.js`, and `lodash.js`. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
62cb11b49ace900e65f6e07cbd93066c37d8fd57. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * refactor: convert `app/scripts/lib/ens-ipfs/contracts/resolver.js` to TypeScript (#41328) [skip-e2e] Part of the ongoing JS→TS migration. Converts the ENS resolver ABI contract file to TypeScript and removes it from the migration dashboard tracking list. ## Changes - **Renamed** `resolver.js` → `resolver.ts` with no functional changes - **Added `as const`** assertion to the ABI array for literal type inference and immutability - **Removed** `"app/scripts/lib/ens-ipfs/contracts/resolver.js"` from `development/ts-migration-dashboard/files-to-convert.json` ```ts // Before (resolver.js) const abi = [ ... ]; export default abi; // After (resolver.ts) const abi = [ ... ] as const; export default abi; ``` The default export is preserved to maintain compatibility with the existing `import resolverAbi from './contracts/resolver'` in `ens-ipfs/resolver.js`. --- ⌨️ Start Copilot coding agent tasks without leaving your editor — available in [VS Code](https://gh.io/cca-vs-code-docs), [Visual Studio](https://gh.io/cca-visual-studio-docs), [JetBrains IDEs](https://gh.io/cca-jetbrains-docs) and [Eclipse](https://gh.io/cca-eclipse-docs). --- > [!NOTE] > **Low Risk** > Low risk refactor of a static ABI export plus a new unit test; main risk is accidental ABI shape drift impacting `ens-ipfs/resolver.js` contract calls. > > **Overview** > Refactors the ENS resolver contract ABI export by replacing `contracts/resolver.js` with a TypeScript `contracts/resolver.ts` that builds the same ABI via small typed helpers and exports it `as const`. > > Adds `resolver.test.ts` to assert the ABI is non-empty and includes key resolver functions, and removes the old JS file from `development/ts-migration-dashboard/files-to-convert.json`. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0f068f7ff22ec5436b4422219612b42ffea40af4. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DDDDDanica <12678455+DDDDDanica@users.noreply.github.com> Co-authored-by: dddddanica * feat: set Sentry user id (#40491) ## **Description** ### Problem we're trying to solve: Today, when we see 100 events in Sentry , we don't know if the issue occurred 100x to the same user VS to 100 different users. ### Solution: This PR sets a userId in Sentry events. Setting a userId in Sentry will allow us to know the number of users impacted by given issue. We decided to use `metaMetricsId` for it, as it's kind of an "installationId" that allows to identify a MM instance: it's unique for every MM instance. Additionally, we did some refactoring. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/40491?quickstart=1) ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1753 ## **Manual testing steps** 1. Update SENTRY_DSN_DEV `.metamaskrc` file with the DSN of your personal Sentry 2. Start Extension with `yarn start` 3. Open the browser console on the MetaMask UI page (not the site you’re browsing) and execute the following script: ``` // Run in the MetaMask fullscreen UI console. MetaMetrics on, SENTRY_DSN_DEV set. const tag = `batch-${Date.now()}`; const sampleUrl = 'http://example.com/path'; const sampleAddr = '0x790A8A9E9bc1C9dB991D8721a92e461Db4CfB235'; // Expect in Sentry: 5 UI issues/events, messages like "[tag] UI 0" … "UI 4" (distinct by index). for (let i = 0; i < 5; i++) { window.stateHooks.captureTestError?.(`[${tag}] UI ${i}`); } // Expect in Sentry: 5 background issues/events, messages like "[tag] BG 0" … "BG 4". for (let i = 0; i < 5; i++) { window.stateHooks.captureBackgroundError?.(`[${tag}] BG ${i}`); } // Expect: message shows ** instead of the http URL, and 0x** instead of the full address (sanitized). window.stateHooks.captureTestError?.( `[${tag}] SAN-UI url+addr fail at ${sampleUrl} holder ${sampleAddr}`, ); // Expect: same sanitization as SAN-UI (URL → **, long 0x address → 0x**), from background context. window.stateHooks.captureBackgroundError?.( `[${tag}] SAN-BG url+addr fail at ${sampleUrl} holder ${sampleAddr}`, ); // Expect: https://codefi.network/ still visible (allowlisted); the trailing bad URL still → **. window.stateHooks.captureTestError?.( `[${tag}] SAN-UI allowed https://codefi.network/ next to bad ${sampleUrl}`, ); ``` 5. Go to Sentry UI and confirm you see 13 issues: 1 Overview

6. Confirm the error messages show ** instead of http URLs (except for allowlisted url like https://codefi.network/) 7. Confirm the error messages show 0x** instead of full Ethereum addresses 8. Confirm the userId is set and corresponds to your `metametricsId`: Screenshot 2026-02-17 at 10 18 19

9. Open the browser console on the MetaMask UI page (not the site you’re browsing) and execute the following script: ``` const identicalUiMessage = '[dedupe-test-ui] identical TestError for dedupeIntegration check'; // Expect: ideally 1 event sent to Sentry from this loop (9 dropped as dupes of the prior). for (let i = 0; i < 10; i++) { window.stateHooks.captureTestError?.(identicalUiMessage); } ``` 10. Go to Sentry UI and confirm you see 1 issue (and not 10) ## **Screenshots/Recordings** See Manual testing steps section ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Medium Risk** > Changes Sentry event processing and transport gating based on MetaMetrics opt-in state, which could affect whether errors/sessions are reported and how users are identified. Risk is mitigated by added unit tests, but regressions could reduce observability if state resolution fails. > > **Overview** > **Sentry events now include a stable user identifier** by attaching `event.user.id` from `metaMetricsId` when MetaMetrics is opted in. > > Refactors MetaMetrics opt-in resolution into new `sentry-get-state` helpers (snapshot → persisted → backup fallback) and replaces the old `filterEvents` integration with a new `metaMetricsIntegration` plus a dedicated `makeTransport` that blocks all Sentry network requests when opted out. > > Updates `beforeBreadcrumb` to use the new participation state, adjusts globals typing (`stateHooks.getBackupState?`, `globalThis.sentry` no longer extended), and adds comprehensive unit tests for state resolution, transport behavior, and the new integration. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8ac6e1e7b58ec21dfc8d91fbfb004b13c8ceb871. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * test: fix flaky test `Settings Redirects to ENS domains when user inputs ENS into address bar` (#41396) ## **Description** This test is flaky as sometimes we are not redirected to the ENS resolved page. We tried to mitigate this by getting the getPersistedState, but that reads fixture data immediately. Instead we will now wait for the live controller state (via Redux) to confirm the ipfsGateway and useAddressBarEnsResolution settings are active. Which reflects the running controller state that has been synced to the UI after background init. ## **Changelog** CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Check ci ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Low Risk** > Test-only change that adjusts a wait condition; no production logic or security-sensitive code is modified. > > **Overview** > Fixes flakiness in the ENS address-bar redirect E2E by switching the readiness check from `window.stateHooks.getPersistedState()` (fixture/IndexedDB) to `getCleanAppState()` (live Redux/controller state). > > The test now waits until both `metamask.ipfsGateway === 'dweb.link'` and `metamask.useAddressBarEnsResolution === true` are active before attempting the ENS navigation/redirect assertion. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
a353c071076714828164cecfe25199fc3801ca9c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} Co-authored-by: Howard Braham * test: Pass new input for Feature Flag Sync PROD job (#41382) ## **Description** 1. **Reason:** Callers of `create-pr-feature-flag-registry-drift` needed more than one GitHub label on the sync PR and sometimes a different title prefix than the hard-coded `[QA] Sync Feature Flag Registry` string, while still keeping the UTC timestamp in the title. 2. **Solution:** - Document and implement **multiple labels** by splitting `pr-label` on commas and newlines, trimming whitespace, and passing one `--label` per value to `gh pr create`. - Add optional input **`pr-title-prefix`** (wired as `PR_TITLE_PREFIX`) so the PR title becomes `"${PR_TITLE_PREFIX} - $TIMESTAMP"`. **Files:** `.github/workflows/create-pr-feature-flag-registry-drift.yml` only. **Note:** This commit sets `pr-title-prefix` default to `test: Sync Feature Flag Registry`. If the intended default for production is `[QA] Sync Feature Flag Registry`, update the workflow default before merge. ## **Changelog** CHANGELOG entry: Extended the feature-flag registry drift reusable workflow to support multiple PR labels and an optional PR title prefix (timestamp suffix unchanged). ## **Related issues** Fixes: N/A ## **Manual testing steps** 1. From a repo that calls this workflow, pass `pr-label` with comma-separated values (e.g. `team-qa, other-label`) and confirm both labels appear on the opened PR. 2. Pass multiline `pr-label` and confirm each line becomes a label. 3. Pass `pr-title-prefix` and confirm the PR title is `{prefix} - {UTC timestamp}`. 4. Omit `pr-title-prefix` and confirm the default prefix from the workflow is used. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Low Risk** > Workflow-only change that tweaks metadata (title/labels) on auto-created PRs; no production runtime code is affected. > > **Overview** > Updates the PROD `check-feature-flag-registry-drift` GitHub Actions workflow to pass new inputs into the reusable `create-pr-feature-flag-registry-drift` workflow. > > Drift PRs created by this job will now use a configurable title prefix (`test: Sync Feature Flag Registry`) and apply multiple labels (`team-qa` and `no-changelog`). > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
eabafd4de5cec78ad5ac64082b1e50e873687e11. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * refactor: migrate onboarding import-srp and password-outdated-modal ui to design-system (#41409) ## **Description** The onboarding flow pages "Import SRP and Password Outdated Modal UI" (seedless onboarding) currently use the legacy component library and design-system constants (Display, AlignItems, JustifyContent, BlockSize, etc.). The codebase is moving to @metamask/design-system-react for consistency and maintainability. Jira Link: https://consensyssoftware.atlassian.net/browse/TO-650 ## **Changelog** CHANGELOG entry: migrate onboarding import-srp and password-outdated-modal ui to design-system ## **Related issues** Fixes: ## **Manual testing steps** 1. Open extension 2. Create Wallet 3. Click on the account list dropdown. 4. Click Add Wallet > Import SRP ## **Screenshots/Recordings** ### **Before** ### **After** Screenshot 2026-04-01 at 12 33
17 PM

Password Outdated Modal: Screenshot 2026-04-01 at 12 47
54 PM

## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Medium Risk** > Mostly a UI refactor, but it touches seed phrase import/onboarding screens and updates DOM structure (buttons/icons), which can impact user flows and automation selectors. > > **Overview** > Migrates the `ImportSrp` onboarding page and `PasswordOutdatedModal` layout from legacy component-library/styled `Box` props to `@metamask/design-system-react`, updating icon/text variants, spacing, and switching some layout to utility `className` usage. > > Updates the `ImportSrp` snapshot to reflect the new rendered DOM (SVG icons, button markup/roles/classes) and adjusts the E2E page object selector for the SRP import “Continue” control (now targeting a `span` instead of a `button`). > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
45eec424f68e0fb6bf66f094bfe59b936f69b8a1. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * fix(accounts): prevent crash when account tree references orphaned account IDs (#41405) ## **Description** When state corruption occurs (e.g. after a wallet reset or Snap keyring reset), the `accountTree` can contain account IDs that no longer exist in `internalAccounts`. In `getWalletsWithAccounts`, spreading `undefined` via `{ ...accountsById[missingId] }` produces an empty object with no `address` property. Downstream, `getWalletIdAndNameByAccountAddress` then calls `.toLowerCase()` on `undefined`, crashing with: ``` TypeError: Cannot read properties of undefined (reading 'toLowerCase') at getWalletIdAndNameByAccountAddress (ui/selectors/multichain-accounts/account-tree.ts) ``` **Root cause:** The account tree references entropy source IDs that no longer exist in the actual keyrings — typically after a user forgets their password and uses the wallet reset flow, or after using Snaps. **Fix:** 1. **`getWalletsWithAccounts`** — added a `.filter()` before `.map()` to skip any account ID that has no entry in `accountsById`. This prevents orphaned entries from ever entering the consolidated wallet data structure. 2. **`getWalletIdAndNameByAccountAddress`** — added optional chaining `acc.address?.toLowerCase()` as a defensive guard. 3. Three regression tests added to prevent future regressions. ## **Changelog** CHANGELOG entry: Fixed a crash that could occur for users with corrupted wallet state after a password reset or Snap keyring usage. ## **Related issues** Fixes: #41141 Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1633 ## **Manual testing steps** This bug is triggered by corrupted state, which is hard to reproduce manually. The fix is covered by unit tests. To verify: 1. Run `yarn test:unit ui/selectors/multichain-accounts/account-tree.test.ts` — all 75 tests should pass. 2. Load the extension normally and verify the account list renders without errors. ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Made with [Cursor](https://cursor.com) --- > [!NOTE] > **Low Risk** > Low risk defensive change in selectors: it only filters out account IDs that cannot be resolved to `internalAccounts`, preventing crashes in downstream lookups. Main impact is that corrupted/stale entries will no longer appear in consolidated wallet/group account lists. > > **Overview** > Prevents crashes when `accountTree` contains stale/orphaned account IDs by filtering unresolved IDs out of `getWalletsWithAccounts` before building the consolidated wallets/groups structure. > > Adds regression tests covering: filtering orphaned IDs from groups, `getWalletIdAndNameByAccountAddress` not throwing with corrupted state, and returning `null` when all referenced accounts are orphaned. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d7796094e9afb31cc34daa65c7173006c7b5f3d1. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * refactor: convert shared/lib/transactions-controller-utils to TypeScript (level 29) (#41333) [skip-e2e] Converts `shared/lib/transactions-controller-utils.js` and its test file to TypeScript, removing both from `files-to-convert.json`. ## Changes - **`transactions-controller-utils.ts`** — typed all exports: - `calcGasTotal`: `string | number` params (was JS untyped, callers pass numbers) - `toPrecisionWithoutTrailingZeros`: `string | number | BigNumber` → `string` - `calcTokenAmount`: `string | number | BigNumber` → `BigNumber` - `getSwapsTokensReceivedFromTxMeta`: all params optional to match existing JS call-site patterns; `chainId: string | number`; `precision: number | null = 6` - Cast `txReceipt` to `{ type?: string }` to access MetaMask's internal envelope-type field (absent from `@metamask/transaction-controller`'s `TransactionReceipt`) - Cast `Log[]` to a local `LogWithTopicsArray[]` type since `Log.topics` is incorrectly typed as `string` instead of `string[]` in the upstream package - **`transactions-controller-utils.test.ts`** (renamed from `transaction-controller-utils.test.js`): - Partial mock objects cast via `as unknown as TransactionMeta` - Added `/* eslint-disable @typescript-eslint/naming-convention */` for `token_to_amount` (external API snake_case property) - Removed spurious second arg from a `.toBe()` call (silently ignored in JS, TypeScript surfaced it) - **`transaction-breakdown-utils.ts`**: removed now-unnecessary `@ts-expect-error` on `precision: null` call (previously required because the JS version had no type for this parameter) --- ✨ Let Copilot coding agent [set things up for you](https://github.com/MetaMask/metamask-extension/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- > [!NOTE] > **Medium Risk** > Mostly a type-migration, but it touches `getSwapsTokensReceivedFromTxMeta` logic (default-token detection, receipt typing, and output formatting), which could subtly affect swaps amount display in the UI. > > **Overview** > **Migrates `shared/lib/transactions-controller-utils` and its tests from JS to TS.** Exports are now explicitly typed (including optional params for `getSwapsTokensReceivedFromTxMeta`) and tests use typed `TransactionMeta` fixtures. > > `getSwapsTokensReceivedFromTxMeta` adds stricter handling around `txReceipt.type`, `chainId` (supports `number` by converting to hex), optional `gasPrice` access, and log topic typing, and slightly changes formatting behavior (e.g., removes an ignored extra arg in a `.toBe()` assertion). The transaction breakdown caller drops an unnecessary `@ts-expect-error` for passing `precision: null`. > > Also removes the converted files from `development/ts-migration-dashboard/files-to-convert.json`. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
170fb3478e19ce9ca94a9bc32db69506b0103585. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DDDDDanica <12678455+DDDDDanica@users.noreply.github.com> Co-authored-by: Danica Shen * refactor: convert shared/lib/object.utils to TypeScript (#41329) [skip-e2e] Converts `shared/lib/object.utils.js` to TypeScript as part of the ongoing TS migration effort. Removes the file from `development/ts-migration-dashboard/files-to-convert.json`. ## Changes - **`shared/lib/object.utils.ts`** — Replaces the `.js` file with proper TypeScript types: - `AllProperties` declared as `unique symbol` - `ObjectMask` intersection type combining a string index signature with an optional `AllProperties` symbol key - `maskObject` typed as `(object: unknown, mask: ObjectMask) => Record | string | null` - Removed JSDoc `{type}` annotations in favour of TypeScript-native types; fixed a pre-existing backtick inconsistency in the JSDoc - **`development/ts-migration-dashboard/files-to-convert.json`** — Removed `"shared/lib/object.utils.js"` entry The existing `.test.ts` file required no changes; its imports resolve to the new `.ts` file automatically. ```typescript export const AllProperties: unique symbol = Symbol('*'); type MaskValue = boolean | ObjectMask; type ObjectMask = { [key: string]: MaskValue; } & { [AllProperties]?: MaskValue; }; export function maskObject( object: unknown, mask: ObjectMask, ): Record | string | null { ... } ``` --- 🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. [Learn more about Advanced Security.](https://gh.io/cca-advanced-security) --- > [!NOTE] > **Medium Risk** > Updates `maskObject` mask semantics (treating array-valued mask entries like `false`) and refactors Sentry state mask typing, which can change what state is captured/sanitized in Sentry payloads. While mostly a TS-typing refactor, it touches error-report context generation and required snapshot updates. > > **Overview** > **Converts `shared/lib/object.utils` to TypeScript** by introducing a typed `ObjectMask` (with `AllProperties` as a `unique symbol`) and adding explicit typings/return types for `maskObject`. > > **Adjusts masking behavior** so array-valued mask entries (e.g. `[]` used in Sentry state masks) are treated like exclusions and replaced with `typeof`/`null` values, and improves error reporting for unsupported mask entries. > > **Updates Sentry state mask definitions** in `app/scripts/constants/sentry-state.ts` to use the shared `ObjectMask` types (and clarifies intent via new docblock), removes the TS-migration dashboard entry for the old JS file, and refreshes metrics e2e snapshots/import ordering to match the new masking output. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0ab2e99610ca8ebe75b503cbd66c90ee276d3240. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DDDDDanica <12678455+DDDDDanica@users.noreply.github.com> Co-authored-by: dddddanica * chore: bump @metamask/hw-wallet-sdk (#41443) ## **Description** This PR bumps `@metamask/hw-wallet-sdk` to the latest version. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: null ## **Manual testing steps** Nothing to test since this is just package bump. ## **Screenshots/Recordings** ### **Before** No UI changes. Nothing to show here. ### **After** No UI changes. Nothing to show here. ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Medium Risk** > Updates a hardware-wallet integration dependency, which could affect Ledger/Trezor connection and signing behavior despite being a simple version/lockfile change. > > **Overview** > Bumps `@metamask/hw-wallet-sdk` from `^0.5.0` to `^0.8.0` and updates `yarn.lock` to resolve the new `0.8.0` package version/checksum (removing the `0.5.0` resolution). > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c26d21a1391befd783b211b43c36e2dc045bafcf. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * feat: bump snap bitcoin 1.10.1 (#41422) ## **Description** Bumps `@metamask/bitcoin-wallet-snap` from `^1.10.0` to `^1.10.1`. Release PR: https://github.com/MetaMask/snap-bitcoin-wallet/pull/595 Notable change: - [fix: include BDK cause in PSBT build error message](https://github.com/MetaMask/snap-bitcoin-wallet/pull/594) — surfaces the underlying BDK root cause (e.g. `InsufficientFunds`, `OutputBelowDustLimit`) in PSBT build error messages so they appear in Sentry/Mixpanel instead of being lost at the RPC boundary. ## **Changelog** CHANGELOG entry: Fixed Bitcoin PSBT build errors now include the underlying cause for better diagnostics ## **Related issues** Fixes: ## **Manual testing steps** 1. Create a Bitcoin account 2. Trigger a PSBT build failure (e.g. insufficient funds swap) 3. Verify the error message in Sentry/Mixpanel includes the BDK cause ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. --- > [!NOTE] > **Low Risk** > Patch-level dependency bump for the Bitcoin snap; primary risk is behavior changes in Bitcoin PSBT build/error propagation affecting diagnostics or edge-case flows. > > **Overview** > Updates the extension’s bundled Bitcoin snap dependency by bumping `@metamask/bitcoin-wallet-snap` from `^1.10.0` to `^1.10.1`, with the corresponding `yarn.lock` resolution/checksum update. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
081af905d95ffec240eda62e5e39e87ebc3f5784. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * feat: add account ordering to Multichain API (#41068) ## **Description** Adds ordering to the `accounts` property in the wallet_getSession response, wallet_createSession response, and wallet_sessionChanged event. Accounts are now ordered by most recently used (lastSelected) This is needed as pre-req work to getting rid of ecosystem specific (solana, tron, other multichain) metamask_accountsChanged events. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/41068?quickstart=1) ## **Changelog** CHANGELOG entry: null Not end user facing. ## **Related issues** Core: https://github.com/MetaMask/core/pull/8255 ## **Manual testing steps** 1. Visit https://metamask.github.io/test-dapp-multichain/latest/ 2. Connect 3 accounts (easiest to only connect one network at time for validation) 3. Change the active account via the wallet UI 4. Note each time you change that the account list reorders in the dapp 5. Check the wallet_sessionChanged events too for ordering 6. Refresh 7. The account order should still be the same as before refreshing 8. Revoke the session 9. Connect the same 3 accounts again to the same network 10. The account order should still be the same as before revoking ## **Screenshots/Recordings** ### **Before** ### **After** https://github.com/user-attachments/assets/d60aa06c-37ae-403c-8d93-c836e34065c6 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Medium Risk** > Touches Multichain API session notifications and adds a delayed `wallet_sessionChanged` broadcast, which could affect dapp session state timing/order. Dependency bumps to `@metamask/multichain-api-middleware` and `@metamask/chain-agnostic-permission` may introduce behavior changes in session scope shaping. > > **Overview** > Adds deterministic ordering to Multichain API session `accounts` by sorting CAIP account IDs using each address’s `lastSelected` rank, and wires this sorter into `getSessionScopes` for `wallet_getSession`, `wallet_createSession`, and `wallet_sessionChanged`. > > Also triggers a `wallet_sessionChanged` notification to *all authorized origins* on `selectedAccountGroupChange` (currently via a temporary 1s `setTimeout` workaround), with new/updated unit tests covering both the sorting behavior and the broadcast. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
28e58b8f65a76247f98ab9311c27e6dca6c5dac8. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} --------- Co-authored-by: MetaMask Bot Co-authored-by: Alex Donesky * fix(ui): reload extension safely from error Try again in popup (#41364) ## **Description** Clicking **Try again** on the global error screen or Shield API error UI used to call `browser.runtime.reload()` from the extension UI document. In Chromium, that can leave a popup-style window showing normal tab content (e.g. the new-tab page) instead of restarting MetaMask cleanly (GitHub issue #29151). This change routes recovery through **`requestSafeReload`** in the service worker: persistence is flushed, **`runtime.reload()` is scheduled after a short delay**, and **`reloadExtensionFromUi`** calls **`requestSafeReload`** then **`window.close()`** so the window is dismissed before reload. Error page and API error handler **Try again** actions use the shared helper instead of calling `browser.runtime.reload()` directly. ## **Changelog** CHANGELOG entry: Fixed an issue where choosing Try again on some error screens could show the browser’s default page inside the MetaMask window instead of restarting the extension. ## **Related issues** Fixes: #29151 ## **Manual testing steps** 1. Build extension with`yarn start` and open it. 2. Use **https://metamask.github.io/test-dapp/** → Connect → **Malformed signatures** → **Invalid type** → expand **Message** on the confirmations screen → confirm the error screen appears. 3. Click **Try again**: the popup should close and the extension should reload; the popup should **not** show your browser’s home/new-tab page inside MetaMask. 4. Optional: **Settings → Developer options → Generate a page crash** (expanded view) → **Try again** and confirm recovery still works. ## **Screenshots/Recordings** ### **Before** https://github.com/user-attachments/assets/181916ba-d734-4dd9-8730-c76abcd60a93 ### **After** https://github.com/user-attachments/assets/8a97e27f-e4b7-4963-8d9a-7c69845f977d ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Low Risk** > Small, localized change to reload sequencing and UI event handlers; main risk is timing-sensitive reload behavior across extension surfaces. > > **Overview** > Fixes UI-triggered extension reloads to avoid Chromium popup/notification windows briefly showing normal tab content. `requestSafeReload` now delays `runtime.reload()` slightly after flushing pending persistence writes, and UI surfaces (Error Page and Shield API error handler) route “Try again” through a new `reloadExtensionFromUi` helper that calls `requestSafeReload` then `window.close()`, with a fallback to direct `runtime.reload()` if the background request fails. > > Adds unit coverage for the new helper and updates existing error-page tests to assert the helper is invoked instead of calling `browser.runtime.reload()` directly. > > ^{Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
81493dc5f1b06c6424656fce1d82f2e84447cf19. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).} * fix: flaky test multi-SRP Reveal Imported SRP (#41438) ## **Description** The multi-SRP E2E tests (`settings-reveal-srp.spec.ts`) are flaky on Firefox CI with the error `Element did not stop moving within the timeout period` at `HeaderNavbar.openGlobalMenu`. See error logs: https://github.com/MetaMask/metamask-extension/actions/runs/23870699799/job/69603211477 https://github.com/MetaMask/metamask-extension/actions/runs/23849417001/job/69526806929 After importing a new SRP, the toast's auto-dismiss animation and background network activity from the new wallet cause continuous layout shifts. This prevents `waitForElementToStopMoving` from detecting the drawer-close-button as stationary within the 5-second timeout on Firefox CI. Fix: Dismiss the SRP-added toast and re-verify homepage stability in `withMultiSrp` before proceeding, following the established `clickElementSafe` pattern for toast dismissal. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - […

Flag DELEGATECALL methods #252

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions