Skip to content

[Bug]: When eth_sign is disabled we fire a Signature Approved event everytime we call the RPC method #17974

@seaona

Description

@seaona

Describe the bug

Problem: when eth_sign is disabled from Advanced settings, we fire a Signature Approved event everytime we call the RPC method. This should not be the case.

This issue was introduced in 10.25.0, by this PR #17308

eth-sign-signature-approved.mp4

Steps to reproduce

  1. Open Segment or open background console for check the network requests to Segment
  2. Disable the functionality of eth_sign from MetaMask Advanced Settings
  3. On another window, go to test dapp
  4. Connect to test dapp
  5. Click Eth Sign
  6. See how the Signature Approved event is fired

Error messages or log output

No response

Version

10.26.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions