This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Fix/remove validate lavamoat app UI from dev ci#605
Merged
cryptotavares merged 3 commits intomainfrom May 24, 2023
Merged
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
71ec830 to
6a39958
Compare
For non release CI execs we want to run both the extension as the desktop popup with the latest version of the common package.
6a39958 to
a7c6b58
Compare
OGPoyraz
approved these changes
May 24, 2023
bergarces
approved these changes
May 24, 2023
vinistevam
approved these changes
May 24, 2023
| yarn ${SCRIPT} | ||
|
|
||
| if git diff --exit-code -- ":(exclude)packages/app/submodules/extension" | ||
| if git diff --exit-code -- ":(exclude)packages/app/submodules/extension" ":(exclude)packages/app/lavamoat" |
Member
There was a problem hiding this comment.
If we're skipping the validation in the case where we've regenerated the UI policies, then do we still need this?
Contributor
Author
There was a problem hiding this comment.
yes you are correct, we don't... but it does not harm having it there.
We should eventually update the git diff to only consider the package.json path and not the entire repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently, if we symlink the common workspace in the extension submodule, we will have a different policy file for the Desktop ui (not only for the Extension). This is due to the desktop popup. The solution is to recreate the desktop ui lavamoat policies on non-release CI executions and ignore the lavamoat validation step.
Changes
Root
Pipeline
Common
None
App
None