This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Chore/package with desktop popup feature enabled#601
Merged
cryptotavares merged 5 commits intomainfrom Mar 17, 2023
Merged
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
approved these changes
Mar 17, 2023
Add desktop popup enable env vars to github package actions. The actions will get the values from the respective github environment variables.
The disableExtensionPopup is only validating if the env vars for desktop popup and disable extension popup are enabled. Then on runtime, the desktop popup can be disabled on by the user on the settings screen. For that reason we need to check if the desktop window handlers are registered or not. If not, it means that the desktop popup is currently disabled on the settings and we want to trigger the extension popup
While testing this feature, realised that there is a race condition between the renderer process updating the desktop popup enabled state (and persisting it) and the main process starting the process of enabling the desktop popup (which requires emiting a restart in order to retrigger the connectRemote for the new desktop popup renderer process). Solving this with a quick hack like adding this sleep as the desktop popup feature is highly experimental and we want to ship the first version of desktop. Furthermore, the impact to the users should be 0, as currently when enabling, the user needs to re-introduce the password into the Extension UI (in order to unlock the vault). Doing that will take longer than the sleep that we are adding
a558bea to
52af8cb
Compare
This is cause by @metamask/network-controller importing an old web3-provider-engine maintained by metamask. That package is still using the long deprecated request package. By passing the issue here, until it is fixed within that package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds desktop popup env vars to the packaging github actions.
Fixes a concurrency issue when enabling/disabling the desktop popup from settings page.
Changes
Pipeline
DESKTOP_POPUPandDISABLE_EXTENSION_POPUPto package dev github action.DESKTOP_POPUPandDISABLE_EXTENSION_POPUPto package prod github action.App