This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Fine tune package GitHub actions env vars#596
Merged
cryptotavares merged 7 commits intomainfrom Mar 8, 2023
Merged
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This was referenced Mar 8, 2023
cryptotavares
commented
Mar 8, 2023
Previously we needed this token for the submodule init (as the submodule was a private repo). Since we have updated the submodule to be the actual MetaMask Extension public repo, there's no need for the access token anymore
This will impact the value of METAMASK_ENVIRONMENT (set it to production)
Currently the only env var required for the UI bundle is the SENTRY_DSN. Everything else is evaluated on the main process
7bab295 to
8ee22e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Minor updates to github package App actions.
Changes
Root
build:ui:lavamoat:cito haveprodas build target. This will allow theMETAMASK_ENVIRONMENTto be set toproduction.Pipeline
None.
Common
None.
App
None.