This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Merged
Conversation
cryptotavares
approved these changes
Mar 8, 2023
e38ba8d to
57d3033
Compare
packages/app/src/ui/README.md
Outdated
| Partial Redux state is being persisted using `redux-persist` library. In order to see what is being persisted, see root reducer in `packages/app/src/ui/ducks/index.js`. | ||
|
|
||
| ### UI State Migration | ||
| Persisted UI states might need to be migrated when the state structure changes. In order to do that, persisted reducers need to be migrated in to latest state structure. This is done by `redux-persist` library. |
Contributor
There was a problem hiding this comment.
"in to latest" => "into latest"
packages/app/src/ui/README.md
Outdated
|
|
||
| ## Styling | ||
| In order to keep the styling consistent with extension styling approach, we use scss modules. This allows us to use the same variables and mixins as the extension. | ||
| MetaMask Desktop styles are combined under `packages/app/src/ui/css/index.scss`. This file imports all the other components scss files which is used in the MM Desktop app. |
Contributor
There was a problem hiding this comment.
"which is used" => "which are used"
gauthierpetetin
approved these changes
Mar 9, 2023
57d3033 to
a2424ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds documentation for UI