This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Merged
Conversation
830875e to
b1dd625
Compare
|
|
||
| if (!app.isPackaged) { | ||
| const image = nativeImage.createFromPath( | ||
| path.resolve(__dirname, '../icons/icon.png'), |
Member
There was a problem hiding this comment.
Rather than duplicate the icon, could we instead update build.sh to copy the icon from packages/app/build into dist/app and reference it there?
32016f7 to
90b51b1
Compare
90b51b1 to
3a3d24d
Compare
matthewwalsh0
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Test