This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Merged
Conversation
dceeaec to
262befb
Compare
75b716e to
64b43b4
Compare
vinistevam
reviewed
Mar 2, 2023
packages/app/src/app/desktop-app.ts
Outdated
| extensionConnection.on('paired', () => { | ||
| this.status.isDesktopPaired = true; | ||
| this.appNavigation.setPairedTrayIcon(); | ||
| this.metricsService.track(EVENT_NAMES.DESKTOP_APP_PAIRED, { |
Contributor
There was a problem hiding this comment.
This event can be removed. I've moved the location to here because it's the place where we save the pairing key while here it was emitting every time the connection is successfully established between MMD and MM.
Member
Author
There was a problem hiding this comment.
Sure thing Vini, thanks for the heads up
vinistevam
approved these changes
Mar 2, 2023
Contributor
vinistevam
left a comment
There was a problem hiding this comment.
Amazing PR 🏆 , just added one small comment.
3cf9675 to
1bead51
Compare
…te-of-the-app-factory-reset
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements factory reset button in the general settings tab.