This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Improve symmetric encryption performance#542
Merged
matthewwalsh0 merged 3 commits intomainfrom Feb 24, 2023
Merged
Conversation
bergarces
approved these changes
Feb 24, 2023
vinistevam
approved these changes
Feb 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improve the performance of the symmetric encryption by removing any hex encoding and instead transferring the encrypted data as byte arrays.
This will be most notable when decrypting many background messages in quick succession, especially large messages such as state messages with the
sendUpdatemethod.The cause of this issue was primarily the hex parsing algorithm in the Browserify
Buffer.frompolyfill. When receiving a background message, browser profiling showed that ~80% of the time spent was simply converting hex data to byte arrays.A synthetic benchmark ran in the extension showed a reduction of 75% from ~1.4ms per iteration to ~0.35ms when decrypting a 5KB message 100,000 times.
Changes
Common
App