This repository was archived by the owner on Oct 22, 2024. It is now read-only.
fix: add graceful shutdown for sentry to flush all pending messages#536
Merged
vinistevam merged 3 commits intomainfrom Feb 26, 2023
Merged
Conversation
97b852d to
4951e36
Compare
a194d97 to
bfd42cf
Compare
bergarces
approved these changes
Feb 24, 2023
Contributor
bergarces
left a comment
There was a problem hiding this comment.
Both the graceful shutdown and adding filter for sentry FE look good to me.
OGPoyraz
approved these changes
Feb 24, 2023
bfd42cf to
c9ea87a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to add a graceful shutdown mechanism for Sentry to send any pending messages.
Changes
App
Issues
resolves #201