Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Use public repo as submodule#517

Merged
matthewwalsh0 merged 42 commits intomainfrom
chore/real-submodule
Feb 27, 2023
Merged

Use public repo as submodule#517
matthewwalsh0 merged 42 commits intomainfrom
chore/real-submodule

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Feb 10, 2023 •
edited
Loading

Overview

Use the public metamask-extension repository as the extension submodule.

Changes

Root

  • Update package scripts to use new extension scripts from app workspace.

Pipeline

  • Create job to update the extension Browserify LavaMoat policies for the desktop build type to dynamically add the external policies needed for the linked @metamask/desktop package.
  • Update Chrome version.

App

  • Replace UI components removed from the extension.
  • Add package scripts to build all variations of desktop extension.
  • Click experimental confirmation button after navigation in extension E2E tests.
  • Update extension E2E hooks to resolve failing tests.
  • Click risk button and whats new close button in app E2E tests.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 10, 2023 •
edited
Loading

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Ignoring: chromedriver@110.0.0, fsevents@1.2.13, playwright@1.23.1

Powered by socket.dev

@matthewwalsh0
Copy link
Copy Markdown
Member Author

matthewwalsh0 commented Feb 26, 2023

@SocketSecurity ignore chromedriver@110.0.0 fsevents@1.2.13 playwright@1.23.1

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review February 26, 2023 11:09
@matthewwalsh0 matthewwalsh0 requested a review from a team February 26, 2023 11:09
bergarces
bergarces reviewed Feb 26, 2023
View reviewed changes
@matthewwalsh0
chore: enable lavamoat for ui
159d526 
Remove heap limit override.
bergarces
bergarces reviewed Feb 27, 2023
View reviewed changes
bergarces
bergarces reviewed Feb 27, 2023
View reviewed changes
cryptotavares
cryptotavares approved these changes Feb 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@cryptotavares cryptotavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The only thing that we need to be aware is that we are not splitting running the pipeline between dev CI and a release CI. We have it split just for Extension releases. This means that whenever we are triggering a release of the Desktop App, we are running the e2e tests with an Extension code base that does not match the Extension repo (as it will have a different common package and different lavamoat policies)

@matthewwalsh0 matthewwalsh0 merged commit 2c7bb47 into main Feb 27, 2023
@matthewwalsh0 matthewwalsh0 deleted the chore/real-submodule branch February 27, 2023 17:35
@cryptotavares cryptotavares mentioned this pull request Mar 1, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bergarces bergarces bergarces left review comments

@cryptotavares cryptotavares cryptotavares approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewwalsh0 @bergarces @cryptotavares