This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Merged
Conversation
bergarces
approved these changes
Feb 6, 2023
matthewwalsh0
approved these changes
Feb 7, 2023
vinistevam
approved these changes
Feb 7, 2023
0ba017b to
61fafbd
Compare
On the extension we are using window.fetch. In order to keep extension changes to its minimum we can just polyfill the window object on desktop side
61fafbd to
af9dc22
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
On the extension we are using window.fetch. In order to keep extension changes to its minimum we can just polyfill the window object on desktop side.
Changes
Root
None
Pipeline
None
Common
None
App
Polyfill global window with node-fetch.