Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Remove common browser#511

Merged
matthewwalsh0 merged 9 commits intomainfrom
chore/remove-common-browser
Feb 7, 2023
Merged

Remove common browser#511
matthewwalsh0 merged 9 commits intomainfrom
chore/remove-common-browser

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Feb 6, 2023

Overview

Remove the browser init logic and instead override webextension-polyfill to use the node-browser.

Changes

Root

  • Update extension init script to use yarn link to use common workspace when building extension.

Pipeline

  • Use extension init script to use common workspace in extension.
  • Ignore the extension submodule when validating Lavamoat policies and allow scripts.

Common

  • Export browser property using webextension-polyfill.
  • Update test globals to satisfy webextension-polyfill.
  • Revert uuid version to match extension and allow yarn linking.

App

  • Set global.browser in browser-init.
  • Add build script to build both app and UI.
  • Update build:app to disable starting app on login.
  • Refactor unit tests.
  • Update LavaMoat policies.

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review February 7, 2023 10:06
@matthewwalsh0 matthewwalsh0 requested a review from a team February 7, 2023 10:06
@matthewwalsh0 matthewwalsh0 merged commit 3735c5c into main Feb 7, 2023
@matthewwalsh0 matthewwalsh0 deleted the chore/remove-common-browser branch February 7, 2023 13:30
@cryptotavares cryptotavares mentioned this pull request Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants