This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Merged
Conversation
c2d14f9 to
2d6af2e
Compare
bergarces
approved these changes
Feb 3, 2023
|
|
||
| // Hides the dock icon | ||
| if (process.platform === 'darwin') { | ||
| app.dock.hide(); |
Member
There was a problem hiding this comment.
I may have misunderstood but I thought the goal was to hide it from the dock only when the app was minimised to the system tray? Having a window in OS X without a dock icon seems unusual to me at least.
Member
Author
There was a problem hiding this comment.
There are definitely use cases that exactly work like this, but it could be my misunderstanding if pick up this way. Lets discuss on dsm
Member
Author
There was a problem hiding this comment.
Thanks for raising it, fixed now
1eafdc9 to
a0c16d4
Compare
a0c16d4 to
18fab02
Compare
…-the-window-is-closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to hide dock icon on app start.