This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Add extension e2e mv3 tests in pipeline#475
Merged
Conversation
9186cc1 to
f2e7c76
Compare
OGPoyraz
approved these changes
Jan 31, 2023
bergarces
reviewed
Jan 31, 2023
| "build:lavamoat": "yarn common build && concurrently -n extension,ui,app \"yarn extension build:desktop:extension:lavamoat\" \"yarn app build:ui:lavamoat\" \"yarn app build:app:prod\"", | ||
| "build:test:app": "yarn common build && concurrently -n extension,ui,app \"yarn extension build:test:desktop:app\" \"yarn app build:ui:lavamoat\" \"yarn app build:app:test:app\"", | ||
| "build:test:extension": "yarn common build && concurrently -n extension,ui,app \"yarn extension build:test:desktop:extension\" \"yarn app build:ui:lavamoat\" \"yarn app build:app:test:extension\"", | ||
| "build:test:extension:mv3": "yarn common build && concurrently -n extension,ui,app \"ENABLE_MV3=true yarn extension build:test:desktop:extension\" \"yarn app build:ui:lavamoat\" \"yarn app build:app:test:extension\"", |
Contributor
There was a problem hiding this comment.
I assume this one is for local execution convenience.
Contributor
Author
There was a problem hiding this comment.
yes, maybe some e2e mv3 test debugging in local
bergarces
approved these changes
Jan 31, 2023
matthewwalsh0
approved these changes
Jan 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Implements:
Run existing e2e tests with desktop app enabled (MV3)#142
Notes: MM e2e mv3 test are not passing in general (Example). They have added a condition to return always a green job with the idea of fix tests gradually. Therefore I have implemented the same pattern to have tests fixed when we rebase.
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.