chore: update electron app folder structure#474
Conversation
6f94195 to
917a5de
Compare
packages/app/.eslintrc.js
Outdated
There was a problem hiding this comment.
desktop-ui.js is the initiator file of desktop-ui, it's relocated in the ui folder. This is why it's removed from here
packages/app/.eslintrc.js
Outdated
There was a problem hiding this comment.
desktop-ui.js file is in the ui folder now, we don't need to include it into array.
packages/app/.eslintrc.ui.js
Outdated
There was a problem hiding this comment.
ui folder is now under the src folder
packages/app/babel-app.config.js
Outdated
There was a problem hiding this comment.
We don't need to compile test files. Probably ts extension forgotten here.
packages/app/.eslintrc.ui.js
Outdated
There was a problem hiding this comment.
Why are all these needed if we are already settings require-jsdoc to false?
There was a problem hiding this comment.
I couldn't make it work tbh, also my local eslint is a bit flaky and working different than CI.
I will check it again
There was a problem hiding this comment.
I'd still vote to remove this check folder as the contents aren't really related.
There was a problem hiding this comment.
Sorry I've misread your comment on that @matthewwalsh0
I am totally fine to leave them on the root
917a5de to
a14c87c
Compare
Overview
The purpose of this PR is mainly to reorganise the src folder.
Here is the final structure