This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Conversation
c1306e4 to
dd41366
Compare
bergarces
reviewed
Jan 27, 2023
| <Provider store={store}> | ||
| <PersistGate loading={null} persistor={persistor}> | ||
| <HashRouter> | ||
| class Root extends PureComponent { |
Contributor
There was a problem hiding this comment.
I was wondering about this, but apparently PureComponents have to be classes.
🤷♂️
Member
Author
There was a problem hiding this comment.
and there are no equivalent hooks for componentDidCatch & getDerivedStateFromError
bergarces
approved these changes
Jan 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements error boundary component to desktop UI.
