Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

fix: hide window on cmd+q and implement warning dialog while desktop …#456

Merged
OGPoyraz merged 4 commits intomainfrom
feat/421-review-the-cmd+q-command
Jan 27, 2023
Merged

fix: hide window on cmd+q and implement warning dialog while desktop …#456
OGPoyraz merged 4 commits intomainfrom
feat/421-review-the-cmd+q-command

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Jan 23, 2023 •
edited
Loading

Overview

  • Change behaviour of CMD+Q, hides window when it's pressed
  • Shows dialog to user and asks if they want to quit (only if desktop is enabled)
    Screenshot 2023-01-23 at 12 41 41

@OGPoyraz OGPoyraz requested a review from a team January 23, 2023 11:44
@OGPoyraz OGPoyraz linked an issue Jan 23, 2023 that may be closed by this pull request
Review the Cmd+Q command #421
Closed
@OGPoyraz OGPoyraz force-pushed the feat/421-review-the-cmd+q-command branch 4 times, most recently from aaea78c to 4d0b083 Compare January 23, 2023 12:23
@OGPoyraz OGPoyraz force-pushed the feat/421-review-the-cmd+q-command branch from 4d0b083 to a64d010 Compare January 23, 2023 12:31
@OGPoyraz OGPoyraz merged commit 0639bf2 into main Jan 27, 2023
@OGPoyraz OGPoyraz deleted the feat/421-review-the-cmd+q-command branch February 1, 2023 07:48
@cryptotavares cryptotavares mentioned this pull request Mar 1, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vinistevam vinistevam vinistevam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review the Cmd+Q command

2 participants

@OGPoyraz @vinistevam