Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

fix: persist metametrics opt in value#453

Merged
OGPoyraz merged 1 commit intomainfrom
feat/401-metametrics-opt-in-page-2
Jan 24, 2023
Merged

fix: persist metametrics opt in value#453
OGPoyraz merged 1 commit intomainfrom
feat/401-metametrics-opt-in-page-2

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Jan 23, 2023

Overview

  • Persists the opt-in value of MetaMetrics
  • Depending on the persisted state of MetaMetrics, app opens either Metametrics or Pair page
  • Fixes external links to open links on the main process
  • Fixes tray bar icon change on restoring the connection
  • Fixes e2e test due to changes on the opening screen order
  • Fixes translations

@OGPoyraz OGPoyraz force-pushed the feat/401-metametrics-opt-in-page-2 branch 3 times, most recently from e8b88a7 to 49f2cc6 Compare January 23, 2023 12:14
@OGPoyraz OGPoyraz force-pushed the feat/401-metametrics-opt-in-page-2 branch from 49f2cc6 to 7ea9ed0 Compare January 23, 2023 12:19
@OGPoyraz OGPoyraz marked this pull request as ready for review January 23, 2023 12:29
@OGPoyraz OGPoyraz requested a review from a team January 23, 2023 12:29
mainWindow?.setMenu(null);
}

const isMetametricsOptionSelected = readPersistedSettingFromAppState({
Copy link
Copy Markdown
Member Author

@OGPoyraz OGPoyraz Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergarces I am looking for isMetametricsOptionSelected here but for your case you will read metametricsOptIn, fyi

Copy link
Copy Markdown
Contributor

@bergarces bergarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OGPoyraz OGPoyraz merged commit 81182ea into main Jan 24, 2023
@OGPoyraz OGPoyraz deleted the feat/401-metametrics-opt-in-page-2 branch February 1, 2023 07:48
@cryptotavares cryptotavares mentioned this pull request Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants