This repository was archived by the owner on Oct 22, 2024. It is now read-only.
chore: split app and extension environment variables#444
Merged
matthewwalsh0 merged 10 commits intomainfrom Jan 20, 2023
Merged
chore: split app and extension environment variables#444matthewwalsh0 merged 10 commits intomainfrom
matthewwalsh0 merged 10 commits intomainfrom
Conversation
Add .metamaskrc.dist to app workspace to list all possible environment variables. Replace app test environment variables with constants. Use Yarn script to clear state in app tests.
Update root readme.
Use env file in windows docker compose. Add packaging envs to example env file.
Update UI LavaMoat policies.
# Conflicts: # packages/app/README.md # packages/app/src/app/app-events.ts
OGPoyraz
approved these changes
Jan 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Split the app and extension environment variables so the app uses a standard
.envfile and the extension continues to use the.metamaskrcfile.Changes
Root
.envif it doesn't exist..metamaskrcfile if it doesn't exist.App
.envfile when building app..envfile when building UI..envfile in Windows packaging docker configuration..env.example..metamaskrc.disttopackages/appand list all possible extension environment variables with descriptions.cfg()usage.App E2E
.env.test.e2ein favour of constants in new app tests helper.