This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Merged
Conversation
d32f342 to
cd1291c
Compare
OGPoyraz
commented
Jan 18, 2023
Member
Author
There was a problem hiding this comment.
@matthewwalsh0 do you remember why we added this timeout?
I've removed it and done the local tests, works pretty smoothly without it.
Member
There was a problem hiding this comment.
On MacOS at least, I got a blank white screen for about a second while React loaded, will re-test locally.
da3dfb6 to
fd6bb6e
Compare
packages/app/src/app/app-events.ts
Outdated
Member
There was a problem hiding this comment.
On my env PR, I've updated the debug env check to use cfg() so best to do the same here.
Member
Author
There was a problem hiding this comment.
Exactly, I saw that in your PR. As soon as it gets merged, I can update it
matthewwalsh0
approved these changes
Jan 20, 2023
fd6bb6e to
087af09
Compare
087af09 to
46876c0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
yes,no,minimizedDESKTOP_PREVENT_OPEN_ON_STARTUPenv variable to prevent startup logic for the development environmentFixes
en,de,frvalue stay in redux, but reading translation values are directly happening from locale JSON files. ( Seepackages/app/ui/contexts/i18n.js)- This will give us the flexibility of what to persist and what not in the root.