Conversation
859cc2d to
4b1dd4d
Compare
fe6b5f6 to
11cfa55
Compare
packages/app/package.json
Outdated
There was a problem hiding this comment.
Sorry for the confusion here, while I don't think the test builds need non-lavamoat versions, I think the UI is fundamental enough that we'll still want to be able to build without Lavamoat.
There was a problem hiding this comment.
This ☝️. We still need to have both build:ui and build:ui:lavamoat. It is just that we are using build:ui:lavamoat for testing purposes.
packages/app/package.json
Outdated
There was a problem hiding this comment.
This shouldn't have to change as the build itself doesn't change, Lavamoat being used is based on which script we start it with. So the E2E tests would instead use start:lavamoat.
packages/app/package.json
Outdated
There was a problem hiding this comment.
Same as for the extension, this doesn't change but we run the app using start:lavamoat.
packages/app/package.json
Outdated
There was a problem hiding this comment.
This can be removed now as the build:ui:ci is much more consistently named.
2a92051 to
07980e4
Compare
9d9f39d to
1d321de
Compare
|
Before merging this one, we have to merge https://github.com/MetaMask/desktop-extension/pull/22 and update the commitid here to match the latest desktop-extension. |
9ec61d5 to
0c50afc
Compare
Explanation
This ticket implements Run existing e2e tests with LavaMoat enabled
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.