Conversation
packages/app/babel-app.config.js
Outdated
There was a problem hiding this comment.
We still have to build the desktop app with a build type, but that can be desktopextension and we can achieve the app specific differences using the overrides object and pre-initialisation as you've started to already.
We could rename the build type to desktop to make it less confusing why the app claims to be the desktop extension.
There was a problem hiding this comment.
Thanks for the clarification, it all make sense now. I will rename it now
packages/app/src/app/globals.ts
Outdated
63bb060 to
b1e3558
Compare
a028811 to
dd5ad78
Compare
e062d38 to
1692193
Compare
There was a problem hiding this comment.
This was introduced due to the init browser changes on the submodule... I believe that we can set all of those to false (as the app should not fall into the path that will use this dependency).
There was a problem hiding this comment.
(to set it to false, you need to add this to the override file and set all those values to false, and then re-run the lavamoat policies generation)
There was a problem hiding this comment.
Thanks @cryptotavares, now I know how to override policies 🙏
Fixed
ea599ca to
a8569a6
Compare
a8569a6 to
27dd896
Compare
Overview
This PR aims to remove
desktopappcode fencing and replace the functionality with the overriding method.It also contains the renaming of
desktopapptodesktopfor code fencing.