Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

chore: support runtime env to test compatibility version#340

Merged
racitores merged 2 commits intomain-desktopfrom
chore/323-compatibility-version-runtime-env
Dec 19, 2022
Merged

chore: support runtime env to test compatibility version#340
racitores merged 2 commits intomain-desktopfrom
chore/323-compatibility-version-runtime-env

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Dec 16, 2022

Overview

Support the COMPATIBILITY_VERSION_DESKTOP_TEST environment variable at runtime to override the compatibility version in the app for testing.

Changes

Root

  • Create build:test:app package script to simplify building all components when running the E2E app tests.

App

  • If UI_TEST env is true, set the compatibility version using the COMPATIBILITY_VERSION_DESKTOP_TEST env if set, or fallback to the COMPATIBILITY_VERSION_DESKTOP env.
  • Exclude new env from transform at build time to support runtime usage.
  • Rename the test build package scripts to be consistent with the test scripts.

Common

  • Make default value optional when reading envs as integers.

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review December 18, 2022 13:13
@matthewwalsh0 matthewwalsh0 requested a review from a team December 18, 2022 13:13
@racitores racitores force-pushed the chore/323-compatibility-version-runtime-env branch from 3436de5 to 2303917 Compare December 19, 2022 11:51
@racitores racitores merged commit 783dc75 into main-desktop Dec 19, 2022
@racitores racitores deleted the chore/323-compatibility-version-runtime-env branch December 19, 2022 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants