This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Add release process for common package#312
Merged
cryptotavares merged 5 commits intomain-desktopfrom Dec 16, 2022
Merged
Conversation
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
66bd406 to
bf8d22d
Compare
bf8d22d to
57cb337
Compare
a43ce3a to
b131b41
Compare
907ba35 to
86a297b
Compare
vinistevam
approved these changes
Dec 15, 2022
OGPoyraz
approved these changes
Dec 16, 2022
matthewwalsh0
approved these changes
Dec 16, 2022
fafddcf to
268215b
Compare
Initialise changelog to common package. The changelog generation should follow MetaMask repos standard.
We are not using MetaMask template yet, because it does not support monorepos with packages with independent versioning
Follow the standard to create a release branch within MetaMask
268215b to
c88cb14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Added a release workflow for the common package (
@MetaMask/desktop).Common package
@MetaMask/auto-changelogand patched it to considercommon/[version]git tags.CI
main-desktopon thepackages/common/directory and the latest commit has the following patterncommon/[version].Ended up not using any of MetaMask actions as none of them support independent monorepo package releases.