Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

chore: refactor pipeline to focus on desktop#304

Merged
matthewwalsh0 merged 5 commits intomain-desktopfrom
chore/243-refactor-ci
Dec 12, 2022
Merged

chore: refactor pipeline to focus on desktop#304
matthewwalsh0 merged 5 commits intomain-desktopfrom
chore/243-refactor-ci

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Dec 8, 2022

Overview

  • Remove extension focused jobs from the pipeline and refactor / add jobs to focus on the common package and the desktop app.
  • Move desktop E2E infrastructure out of the extension.

Changes

Pipeline

  • Remove unnecessary executors.
  • Remove all release jobs.
  • Split prep jobs steps into separate jobs to support parallelism and a quicker pipeline.
  • Add job to validate all LavaMoat config.
  • Refactor depcheck and audit to run against desktop workspaces.
  • Include Yarn cache directory in Circle CI cache to speed up cached installs. (~7 Minutes > ~5 Minutes)
  • Reduce pipeline duration. (~45 Minutes > ~19 Minutes)

Root

  • App depcheck config file.
  • Add improved-yarn-audit config file.
  • Add allow-scripts dependency and related setup:postinstall package script.
  • Add dependencies:
    • @lavamoat/allow-scripts
    • depcheck
    • improved-yarn-audit
    • lockfile-lint

Common

  • Add depcheck config file.
  • Add allow-scripts dependency and related setup:postinstall package script.
  • Remove unnecessary eslint dependencies.

App

  • Create hook.js to be loaded when running extension E2E tests to inject desktop helper functions.
  • Add depcheck config file.
  • Add package scripts to run extension E2E tests with desktop app.

Extension

  • Remove desktop E2E package scripts.
  • Remove usages of desktop E2E helper functions.
  • Support E2E_ARGS env in E2E tests to include custom Mocha arguments.

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review December 8, 2022 16:44
@matthewwalsh0 matthewwalsh0 requested a review from a team December 8, 2022 16:44
Fix linting errors.
Fix depcheck errors.
Fix lavamoat job.
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great to have a pipeline focused on the desktop app!

@matthewwalsh0 matthewwalsh0 merged commit 3a261a0 into main-desktop Dec 12, 2022
@matthewwalsh0 matthewwalsh0 deleted the chore/243-refactor-ci branch December 12, 2022 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants