This repository was archived by the owner on Oct 22, 2024. It is now read-only.
fix: resolve pairing issues in firefox#291
Merged
matthewwalsh0 merged 4 commits intomain-desktopfrom Dec 6, 2022
Merged
Conversation
3c594c5 to
7b8ec98
Compare
bergarces
approved these changes
Dec 2, 2022
Contributor
bergarces
left a comment
There was a problem hiding this comment.
I can't find anything to comment on. It feels like a great improvement and we will have better error reporting if/when something goes wrong initialising a websocket connection.
matthewwalsh0
commented
Dec 2, 2022
vinistevam
approved these changes
Dec 2, 2022
6a436c0 to
de384c3
Compare
f1029b0 to
a56f111
Compare
cryptotavares
approved these changes
Dec 5, 2022
Remove desktop connection on extension startup. Add encryption handshake timeout and graceful web socket close. Add automatic retry to both sides of encryption handshake.
a56f111 to
9f7d718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolve issues preventing successful pairing in Firefox.
Changes
App
Common