This repository was archived by the owner on Oct 22, 2024. It is now read-only.
chore: move high level classes to common workspace#288
Merged
matthewwalsh0 merged 6 commits intomain-desktopfrom Dec 6, 2022
Merged
chore: move high level classes to common workspace#288matthewwalsh0 merged 6 commits intomain-desktopfrom
matthewwalsh0 merged 6 commits intomain-desktopfrom
Conversation
267e172 to
36babc3
Compare
matthewwalsh0
commented
Dec 1, 2022
Move DesktopManager, DesktopConnection, ExtensionPairing, and DesktopController to common workspace.
Use logging wrapper in common workspace to set default log level consistently. Add common to build scripts in root package. Remove generated files.
6a436c0 to
de384c3
Compare
Contributor
|
Looks great! Just bring it up to date, as it is still referencing electron-22 alpha on yarn.lock |
Member
Author
This wasn't actually a change in this branch as the extension in |
cryptotavares
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Move remaining high level classes to common workspace.
Changes
App
isDesktopAppproperty to easily identify if running in app.mocks.ts.Common
ExtensionPairingDesktopConnectionDesktopManagerDesktopControllerDesktopControllerfromDesktopManagerandDesktopAppusing interfaces and init methods.