This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Move extension to separate directory#271
Merged
matthewwalsh0 merged 20 commits intomain-desktopfrom Nov 25, 2022
Merged
Conversation
Remove unnecessary dependencies in extension. Update LavaMoat policies.
Fix linting errors. Add standard linting config to app.
Create build, lint, and test CI jobs for app workspace. Add linting scripts to app. Update root readme.
Fix packaging scripts. Fix UI LavaMoat policies. Update root readme.
Add test parsing to app test job in CI.
d28bf9c to
5cd19e3
Compare
Run desktop E2E tests with LavaMoat enabled.
Experiment with increased timeouts for E2E tests.
OGPoyraz
approved these changes
Nov 25, 2022
cryptotavares
approved these changes
Nov 25, 2022
Contributor
cryptotavares
left a comment
There was a problem hiding this comment.
Nice one! Really liked that the submodule can be considered a package 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Move all original extension code to
packages/app/submodules/extensionleaving only the app specific code inpackages/app.Changes
package.jsonforappworkspace with namedesktop-app.package.json.jest.config.jsandtestscript forappworkspace.packages/app/build.yarn extensionscript to easily run scripts against extension package.buildandbuild:lavamoatscripts to build app, UI, and extension simultaneously.