This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Move encryption and generic utils to common workspace#264
Merged
cryptotavares merged 4 commits intomain-desktopfrom Nov 22, 2022
Merged
Conversation
45c515d to
8616b03
Compare
Member
There was a problem hiding this comment.
Do we definitely want to export this from it's own file rather than just @metamask/desktop/dist/encryption?
Contributor
Author
There was a problem hiding this comment.
I kept it on its own file, otherwise I would have to export both web-socket + symmetric + asymmetric encryption from there... And to do that I would either have to rename methods from those or export contained on its own object (example symmetric.encrypt). I though about it, but then we would need to distinguish which methods/objects/classes/etc are to be exported as root or as "namespaced" by an object. Decided to leave that decision for later 😅
I have removed the encryption from file naming though (as it was redundant).
matthewwalsh0
approved these changes
Nov 22, 2022
Remove encryption, totp, and utils from desktop app, and start using the ones from the common desktop package
8616b03 to
c675652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Move the encryption (asymmetric, symmetric, and web sockets streams), totp as well as all required utils (crypto, generic utils and background types).
Changes
Move the following to the common workspace: