This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Move browser and version check logic to common workspace#259
Merged
matthewwalsh0 merged 17 commits intomain-desktopfrom Nov 22, 2022
Merged
Move browser and version check logic to common workspace#259matthewwalsh0 merged 17 commits intomain-desktopfrom
matthewwalsh0 merged 17 commits intomain-desktopfrom
Conversation
ec7a63e to
79f910c
Compare
Remove desktop property from config object. Upgrade Mocha to version 8.
Rename unnecessary index files. Update LavaMoat policies.
caeaeab to
dcdeb18
Compare
cryptotavares
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Move the browser and version check logic, along with required utils and types, to the common workspace.
Changes
shared/version-check(Extension Code Only)browser/browser-polyfillbrowser/browser-proxyutils/config(Extension Variables Only)utils/raw-statetypes/backgroundtypes/browsertypes/desktopindex.tsfiles in subdirectories to enable modular package imports.browser-polyfillto useinitBrowserto avoid needingnode-browserin the package.utils/raw-statemethods to have more context.desktopproperty in configs.