Skip to content

fix: example screen error#715

Merged
georgewrmarshall merged 2 commits into
mainfrom
fix/example-error
Jun 3, 2025
Merged

fix: example screen error#715
georgewrmarshall merged 2 commits into
mainfrom
fix/example-error

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue in the Storybook examples where the AvatarAccount component was missing a required address prop. The empty address string was causing rendering issues in the component preview.

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the React Native Storybook yarn storybook:ios
  2. Navigate to Examples/Wallet Home story
  3. Verify that the AvatarAccount component renders correctly with the provided address
  4. Confirm that no console errors are present related to missing props

Screenshots/Recordings

Before

before.mov

After

after.mov

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall self-assigned this Jun 3, 2025
@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 3, 2025 01:51
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner June 3, 2025 01:51
@georgewrmarshall georgewrmarshall changed the title fix: adding address to example screens fix: example screen error Jun 3, 2025
@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall merged commit 2eee7ca into main Jun 3, 2025
37 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/example-error branch June 3, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants