Skip to content

Feat/vscode settings initialized#7

Merged
garrettbear merged 4 commits into
mainfrom
feat/vscode-settings-initialized
Oct 1, 2024
Merged

Feat/vscode settings initialized#7
garrettbear merged 4 commits into
mainfrom
feat/vscode-settings-initialized

Conversation

@garrettbear

@garrettbear garrettbear commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

Description

This pull request introduces a .vscode folder with the following default settings and extensions:

  • Extensions: ESLint (dbaeumer.vscode-eslint) and Prettier (esbenp.prettier-vscode).
  • Settings: Customizes the color of the VS Code UI, including active/inactive title bar background and foreground, as well as the activity bar border.

These changes aim to standardize the development environment and improve code quality by ensuring consistent formatting and linting.

Related issues

Fixes: N/A

Manual testing steps

  1. Pull the branch and open the project in VS Code.
  2. Verify that the recommended extensions (ESLint and Prettier) are suggested upon opening the project.
  3. Check that the custom color settings are applied to the VS Code UI:
    • Active title bar background and foreground colors.
    • Inactive title bar background and foreground colors.
    • Activity bar border.

Screenshots/Recordings

Before

Inactive
Screenshot 2024-09-23 at 9 35 07 AM
Active
Screenshot 2024-09-23 at 9 35 00 AM

After

Inactvie
Screenshot 2024-09-23 at 9 41 21 AM
Active
Screenshot 2024-09-23 at 9 41 11 AM

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines).

Pre-merge reviewer checklist

  • I've manually tested the PR.
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Comment thread README.md Outdated
@garrettbear garrettbear marked this pull request as ready for review September 24, 2024 17:52
@garrettbear garrettbear requested a review from a team as a code owner September 24, 2024 17:52

@georgewrmarshall georgewrmarshall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple questions

Comment thread .vscode/settings.json
Comment thread .vscode/extensions.json

@georgewrmarshall georgewrmarshall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@garrettbear garrettbear merged commit f9b3551 into main Oct 1, 2024
@garrettbear garrettbear deleted the feat/vscode-settings-initialized branch October 1, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request team-design-system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants