Skip to content

chore: removing unused fonts folder and files from design-tokens#131

Merged
georgewrmarshall merged 1 commit into
mainfrom
fix/remove-fonts
Nov 19, 2024
Merged

chore: removing unused fonts folder and files from design-tokens#131
georgewrmarshall merged 1 commit into
mainfrom
fix/remove-fonts

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

Description

As part of the design tokens migration, this pull request removes the unused fonts folder and files from the merged-packages/design-tokens directory. These fonts were previously used for Storybook, but they are now duplicated and unnecessary because the storybook-react application (apps/storybook-react/fonts) provides the required fonts.

Related

Manual Testing Steps

  1. Ensure fonts/ folder and files have been removed from merged-packages/design-tokens
  2. Ensure there are no references to merge-packages/design-tokens/docs/fonts folder or files in the codebase

Screenshots

Ensuring merge-packages/design-tokens/docs/fonts folder is not referenced in the codebase

Screenshot 2024-11-18 at 3 03 41 PM

Pre-merge Author Checklist

  • Followed MetaMask Contributor Docs.
  • Ensured all PR status checks passed at least once.
  • Updated relevant CHANGELOG files.
  • Applied appropriate labels and linked issues.

Pre-merge Reviewer Checklist

  • Verified manual tests for the build and migration.
  • Reviewed CHANGELOG entries and downstream dependency updates.
  • Checked for unresolved TODOs in the codebase.

@georgewrmarshall georgewrmarshall self-assigned this Nov 18, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review November 18, 2024 22:59
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 18, 2024 22:59
@georgewrmarshall georgewrmarshall merged commit 73bd291 into main Nov 19, 2024
@georgewrmarshall georgewrmarshall deleted the fix/remove-fonts branch November 19, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants