chore: removing unused fonts folder and files from design-tokens#131
Merged
Conversation
8ee19f8 to
3c7f95e
Compare
7 tasks
brianacnguyen
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of the design tokens migration, this pull request removes the unused
fontsfolder and files from themerged-packages/design-tokensdirectory. These fonts were previously used for Storybook, but they are now duplicated and unnecessary because thestorybook-reactapplication (apps/storybook-react/fonts) provides the required fonts.Related
Manual Testing Steps
fonts/folder and files have been removed frommerged-packages/design-tokensmerge-packages/design-tokens/docs/fontsfolder or files in the codebaseScreenshots
Ensuring
merge-packages/design-tokens/docs/fontsfolder is not referenced in the codebasePre-merge Author Checklist
Pre-merge Reviewer Checklist