Skip to content

docs: remove popper mentions#1214

Merged
georgewrmarshall merged 1 commit into
mainfrom
docs/remove-popper-mentions
Jun 4, 2026
Merged

docs: remove popper mentions#1214
georgewrmarshall merged 1 commit into
mainfrom
docs/remove-popper-mentions

Conversation

@kirillzyusko

@kirillzyusko kirillzyusko commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Description

Follow up for #1153

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-313

Manual testing steps

This is just PR with addressing comments from previous PR.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Documentation-only edits to migration and README; no code or dependency changes in this PR.

Overview
Updates Popover migration and Storybook docs so they describe @floating-ui/react-dom as the internal positioning stack instead of react-popper, matching the implementation from the prior PR.

MIGRATION.md revises the Popover section: positioning library notes, referenceElement description, default/behavior table (including arrow rendering as a real <Box> child), and API differences. Popover/README.mdx updates the intro and references link accordingly. No runtime or API behavior changes in this diff.

Reviewed by Cursor Bugbot for commit 3b7c784. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

@kirillzyusko kirillzyusko self-assigned this Jun 4, 2026
@kirillzyusko kirillzyusko added the documentation Improvements or additions to documentation label Jun 4, 2026
@kirillzyusko kirillzyusko marked this pull request as ready for review June 4, 2026 09:34
@kirillzyusko kirillzyusko requested a review from a team as a code owner June 4, 2026 09:34
@georgewrmarshall georgewrmarshall merged commit f4da21b into main Jun 4, 2026
37 checks passed
@georgewrmarshall georgewrmarshall deleted the docs/remove-popper-mentions branch June 4, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants