fix(BannerBase): prevent bare numeric render by using nullish presence checks for title/description/children in RN and Web variants (handles 0 correctly) [bugfix: 496705ba-2f78-456c-8daa-4ccc689d490b]

cursoragent · cursoragent · commit de46f7202162 · 2026-03-04T01:50:36.000Z
diff --git a/packages/design-system-react-native/src/components/BannerBase/BannerBase.tsx b/packages/design-system-react-native/src/components/BannerBase/BannerBase.tsx
@@ -69,7 +69,8 @@ export const BannerBase: React.FC<BannerBaseProps> = ({
       {startAccessory}
 
       <Box twClassName="flex-1">
-        {title &&
+        {title !== null &&
+          title !== undefined &&
           (isTextContent(title) ? (
             <Text
               variant={TextVariant.BodyMd}
@@ -82,7 +83,7 @@ export const BannerBase: React.FC<BannerBaseProps> = ({
             title
           ))}
 
-        {description && (
+        {description !== null && description !== undefined && (
           <Box twClassName={title ? 'mt-1' : undefined}>
             {isTextContent(description) ? (
               <Text variant={TextVariant.BodySm} {...descriptionProps}>
@@ -94,7 +95,8 @@ export const BannerBase: React.FC<BannerBaseProps> = ({
           </Box>
         )}
 
-        {children &&
+        {children !== null &&
+          children !== undefined &&
           (isTextContent(children) ? (
             <Text variant={TextVariant.BodyMd} {...childrenWrapperProps}>
               {children}
diff --git a/packages/design-system-react/src/components/BannerBase/BannerBase.tsx b/packages/design-system-react/src/components/BannerBase/BannerBase.tsx
@@ -66,7 +66,8 @@ export const BannerBase = forwardRef<HTMLDivElement, BannerBaseProps>(
         {startAccessory}
 
         <Box className="min-w-0 flex-1">
-          {title &&
+          {title !== null &&
+            title !== undefined &&
             (isTextContent(title) ? (
               <Text
                 variant={TextVariant.BodyMd}
@@ -79,7 +80,8 @@ export const BannerBase = forwardRef<HTMLDivElement, BannerBaseProps>(
               title
             ))}
 
-          {description && (
+          {description !== null &&
+            description !== undefined && (
             <Box className={title ? 'mt-1' : undefined}>
               {isTextContent(description) ? (
                 <Text variant={TextVariant.BodySm} {...descriptionProps}>
@@ -91,7 +93,8 @@ export const BannerBase = forwardRef<HTMLDivElement, BannerBaseProps>(
             </Box>
           )}
 
-          {children &&
+          {children !== null &&
+            children !== undefined &&
             (isTextContent(children) ? (
               <Text variant={TextVariant.BodyMd} {...childrenWrapperProps}>
                 {children}
