react-native: remove dead updateScrollYFromEvent and its tests; adjust per-file coverage thresholds for useHeaderStandardAnimated

cursoragent · cursoragent · commit d4ba8ba5e940 · 2026-05-22T18:09:16.000Z
diff --git a/packages/design-system-react-native/jest.config.js b/packages/design-system-react-native/jest.config.js
@@ -23,15 +23,14 @@ module.exports = merge(baseConfig, {
       statements: 100,
     },
     // useAnimatedScrollHandler wraps onScroll in a Reanimated worklet; Jest uses the
-    // reanimated mock, which does not execute that worklet body. Scroll logic is covered
-    // via updateScrollYFromEvent unit tests, but the hook line that forwards scrollEvent
-    // into updateScrollYFromEvent stays uncovered here—so statements/lines/functions sit
-    // below 100% while branches remain fully exercised.
+    // reanimated mock, which does not execute that worklet body. As a result, the
+    // inline scroll handler line remains uncovered in unit tests—so statements/lines/
+    // functions sit below 100% while branches remain fully exercised.
     './src/components/HeaderStandardAnimated/useHeaderStandardAnimated.ts': {
       branches: 100,
-      functions: 75,
-      lines: 87,
-      statements: 87,
+      functions: 66,
+      lines: 85,
+      statements: 85,
     },
     // pressed && !isDisabled branch in getPressableStyle is not unit-testable without
     // react-test-renderer internals (see https://github.com/MetaMask/metamask-design-system/issues/1182).
diff --git a/packages/design-system-react-native/src/components/HeaderStandardAnimated/useHeaderStandardAnimated.test.ts b/packages/design-system-react-native/src/components/HeaderStandardAnimated/useHeaderStandardAnimated.test.ts
@@ -1,12 +1,8 @@
 // Third party dependencies.
 import { renderHook, act } from '@testing-library/react-native';
-import type { SharedValue } from 'react-native-reanimated';
 
 // Internal dependencies.
-import {
-  updateScrollYFromEvent,
-  useHeaderStandardAnimated,
-} from './useHeaderStandardAnimated';
+import { useHeaderStandardAnimated } from './useHeaderStandardAnimated';
 
 jest.mock('react-native-reanimated', () =>
   jest.requireActual('react-native-reanimated/mock'),
@@ -68,11 +64,6 @@ describe('useHeaderStandardAnimated', () => {
     });
   });
 
-  describe('updateScrollYFromEvent', () => {
-    it('writes contentOffset.y to the shared value', () => {
-      const scrollYValue = { value: 0 } as unknown as SharedValue<number>;
-      updateScrollYFromEvent(scrollYValue, 82);
-      expect(scrollYValue.value).toBe(82);
-    });
-  });
+  // onScroll is a Reanimated worklet; the jest reanimated mock does not execute
+  // the worklet body, so the scrollY write is not unit-testable here.
 });
diff --git a/packages/design-system-react-native/src/components/HeaderStandardAnimated/useHeaderStandardAnimated.ts b/packages/design-system-react-native/src/components/HeaderStandardAnimated/useHeaderStandardAnimated.ts
@@ -1,6 +1,5 @@
 // Third party dependencies.
 import { useCallback } from 'react';
-import type { SharedValue } from 'react-native-reanimated';
 import {
   useSharedValue,
   useAnimatedScrollHandler,
@@ -9,19 +8,6 @@ import {
 // Internal dependencies.
 import type { UseHeaderStandardAnimatedReturn } from './HeaderStandardAnimated.types';
 
-/**
- * Writes a vertical content offset into the scroll shared value.
- *
- * @param scrollYValue - Shared value for vertical scroll offset.
- * @param contentOffsetY - `contentOffset.y` from the scroll event.
- */
-export function updateScrollYFromEvent(
-  scrollYValue: SharedValue<number>,
-  contentOffsetY: number,
-) {
-  scrollYValue.value = contentOffsetY;
-}
-
 /**
  * Hook for managing HeaderStandardAnimated scroll-linked animations.
  * Use with HeaderStandardAnimated placed outside the ScrollView as a sibling.
