Skip to content

Commit 394e624

Browse files
committed
fix(BannerAlert): ensure severity-driven props override consumer props by moving spread before computed props in web and RN
1 parent 13c015c commit 394e624

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/design-system-react-native/src/components/BannerAlert/BannerAlert.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export const BannerAlert: React.FC<BannerAlertProps> = ({
3838

3939
return (
4040
<BannerBase
41+
{...props}
4142
startAccessory={
4243
<Icon
4344
testID={BANNER_ALERT_ICON_TEST_ID}
@@ -49,7 +50,6 @@ export const BannerAlert: React.FC<BannerAlertProps> = ({
4950
backgroundColor={backgroundColor}
5051
paddingLeft={2}
5152
twClassName={mergedTwClassName}
52-
{...props}
5353
/>
5454
);
5555
};

packages/design-system-react/src/components/BannerAlert/BannerAlert.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export const BannerAlert = forwardRef<HTMLDivElement, BannerAlertProps>(
3535
return (
3636
<BannerBase
3737
ref={ref}
38+
{...props}
3839
startAccessory={
3940
<Icon
4041
data-testid={BANNER_ALERT_ICON_TEST_ID}
@@ -46,7 +47,6 @@ export const BannerAlert = forwardRef<HTMLDivElement, BannerAlertProps>(
4647
backgroundColor={backgroundColor}
4748
paddingLeft={2}
4849
className={mergedClassName}
49-
{...props}
5050
/>
5151
);
5252
},

0 commit comments

Comments
 (0)